Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2805)

Unified Diff: components/offline_pages/offline_page_metadata_store_sql.cc

Issue 2353393002: [Offline pages] Extracting and templatizing types for store callbacks (Closed)
Patch Set: Removing offline_store_types_impl.h Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_metadata_store_sql.cc
diff --git a/components/offline_pages/offline_page_metadata_store_sql.cc b/components/offline_pages/offline_page_metadata_store_sql.cc
index c366f84f253872849ea97149004a7d0bdf5a6faf..0a2b22159d9bdbbe5c4372c970c7c4d1cfff931e 100644
--- a/components/offline_pages/offline_page_metadata_store_sql.cc
+++ b/components/offline_pages/offline_page_metadata_store_sql.cc
@@ -331,7 +331,8 @@ void PostStoreUpdateResultForIds(
const std::vector<int64_t>& offline_ids,
ItemActionStatus action_status,
const OfflinePageMetadataStore::UpdateCallback& callback) {
- std::unique_ptr<StoreUpdateResult> result(new StoreUpdateResult(store_state));
+ std::unique_ptr<OfflinePagesUpdateResult> result(
+ new OfflinePagesUpdateResult(store_state));
for (const auto& offline_id : offline_ids)
result->item_statuses.push_back(std::make_pair(offline_id, action_status));
runner->PostTask(FROM_HERE, base::Bind(callback, base::Passed(&result)));
@@ -361,8 +362,8 @@ void UpdateOfflinePagesSync(
scoped_refptr<base::SingleThreadTaskRunner> runner,
const std::vector<OfflinePageItem>& pages,
const OfflinePageMetadataStore::UpdateCallback& callback) {
- std::unique_ptr<StoreUpdateResult> result(
- new StoreUpdateResult(StoreState::LOADED));
+ std::unique_ptr<OfflinePagesUpdateResult> result(
+ new OfflinePagesUpdateResult(StoreState::LOADED));
sql::Transaction transaction(db);
if (!transaction.Begin()) {
@@ -394,8 +395,8 @@ void RemoveOfflinePagesSync(
scoped_refptr<base::SingleThreadTaskRunner> runner,
const OfflinePageMetadataStore::UpdateCallback& callback) {
// TODO(fgorski): Perhaps add metrics here.
- std::unique_ptr<StoreUpdateResult> result(
- new StoreUpdateResult(StoreState::LOADED));
+ std::unique_ptr<OfflinePagesUpdateResult> result(
+ new OfflinePagesUpdateResult(StoreState::LOADED));
// If you create a transaction but don't Commit() it is automatically
// rolled back by its destructor when it falls out of scope.

Powered by Google App Engine
This is Rietveld 408576698