Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: components/offline_pages/offline_page_metadata_store_impl_unittest.cc

Issue 2353393002: [Offline pages] Extracting and templatizing types for store callbacks (Closed)
Patch Set: Removing offline_store_types_impl.h Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_metadata_store_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_metadata_store_impl_unittest.cc b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
index b73b5744aff442a67d81d896861d55b747748434..fd89194257ff7256bbca98d6e7856726e6912994 100644
--- a/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
+++ b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
@@ -235,7 +235,7 @@ class OfflinePageMetadataStoreTest : public testing::Test {
const std::vector<OfflinePageItem>& offline_pages);
void AddCallback(ItemActionStatus status);
void UpdateCallback(CalledCallback called_callback,
- std::unique_ptr<StoreUpdateResult> result);
+ std::unique_ptr<OfflinePagesUpdateResult> result);
void ResetCallback(bool status);
void ClearResults();
@@ -244,12 +244,14 @@ class OfflinePageMetadataStoreTest : public testing::Test {
void CheckThatOfflinePageCanBeSaved(
std::unique_ptr<OfflinePageMetadataStore> store);
- StoreUpdateResult* last_update_result() { return last_update_result_.get(); }
+ OfflinePagesUpdateResult* last_update_result() {
+ return last_update_result_.get();
+ }
protected:
CalledCallback last_called_callback_;
Status last_status_;
- std::unique_ptr<StoreUpdateResult> last_update_result_;
+ std::unique_ptr<OfflinePagesUpdateResult> last_update_result_;
std::vector<OfflinePageItem> offline_pages_;
OfflinePageMetadataStoreFactory factory_;
@@ -291,7 +293,7 @@ void OfflinePageMetadataStoreTest::AddCallback(ItemActionStatus status) {
void OfflinePageMetadataStoreTest::UpdateCallback(
CalledCallback called_callback,
- std::unique_ptr<StoreUpdateResult> result) {
+ std::unique_ptr<OfflinePagesUpdateResult> result) {
last_called_callback_ = called_callback;
last_status_ = result->updated_items.size() > 0 ? STATUS_TRUE : STATUS_FALSE;
last_update_result_ = std::move(result);
« no previous file with comments | « components/offline_pages/offline_page_metadata_store.cc ('k') | components/offline_pages/offline_page_metadata_store_sql.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698