Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2353333003: Rename CreateFromDer() to Create(). (Closed)

Created:
4 years, 2 months ago by eroman
Modified:
4 years, 2 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, fuzzing_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CreateFromDer() to Create(). This is consistent with ParsedCertificate::Create() and SignatureAlgorithm::Create(). Committed: https://crrev.com/9fedeb4a20a15ff8b66fd8ec108ad3597f336463 Cr-Commit-Position: refs/heads/master@{#420549}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -94 lines) Patch
M net/cert/internal/name_constraints.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/internal/name_constraints.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/internal/name_constraints_unittest.cc View 37 chunks +62 lines, -82 lines 0 comments Download
M net/cert/internal/parse_certificate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/internal/parse_certificate_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/parsed_certificate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/cert/x509_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
eroman
4 years, 2 months ago (2016-09-22 07:15:06 UTC) #2
mattm
lgtm
4 years, 2 months ago (2016-09-23 00:51:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353333003/40001
4 years, 2 months ago (2016-09-23 01:36:00 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-23 02:30:48 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 02:32:44 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9fedeb4a20a15ff8b66fd8ec108ad3597f336463
Cr-Commit-Position: refs/heads/master@{#420549}

Powered by Google App Engine
This is Rietveld 408576698