net/cert/x509_util.cc - Issue 2353333003: Rename CreateFromDer() to Create().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_util.cc

Issue 2353333003: Rename CreateFromDer() to Create(). (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_util.cc

diff --git a/net/cert/x509_util.cc b/net/cert/x509_util.cc

index 9b0cf51466bc3b708c62f446172035d0d4a270b4..35913c19d2b5cd1ba2e7eee46ddf9aa4e9844f0d 100644

--- a/net/cert/x509_util.cc

+++ b/net/cert/x509_util.cc

@@ -159,7 +159,7 @@ bool ParseCertificateSandboxed(const base::StringPiece& certificate,

auto iter = extensions.find(SubjectAltNameOid());

if (iter != extensions.end()) {

std::unique_ptr<GeneralNames> subject_alt_names =

- GeneralNames::CreateFromDer(iter->second.value);

+ GeneralNames::Create(iter->second.value);

if (subject_alt_names) {

*dns_names = subject_alt_names->dns_names;

for (const auto& ip : subject_alt_names->ip_addresses)

« no previous file with comments | « net/cert/internal/parsed_certificate.cc ('k') | no next file » | no next file with comments »