Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: net/cert/internal/parsed_certificate.cc

Issue 2353333003: Rename CreateFromDer() to Create(). (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/parse_certificate_fuzzer.cc ('k') | net/cert/x509_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parsed_certificate.cc
diff --git a/net/cert/internal/parsed_certificate.cc b/net/cert/internal/parsed_certificate.cc
index 6d1a071bce53e0bf04714caebd4d7eb822c2c095..8b990464205c9a22e8d6e52260618c705e58f072 100644
--- a/net/cert/internal/parsed_certificate.cc
+++ b/net/cert/internal/parsed_certificate.cc
@@ -104,7 +104,7 @@ scoped_refptr<ParsedCertificate> ParsedCertificate::CreateInternal(
}
// Attempt to parse the signature algorithm contained in the Certificate.
- // Do not give up on failure here, since SignatureAlgorithm::CreateFromDer
+ // Do not give up on failure here, since SignatureAlgorithm::Create
// will fail on valid but unsupported signature algorithms.
// TODO(mattm): should distinguish between unsupported algorithms and parsing
// errors.
@@ -155,8 +155,8 @@ scoped_refptr<ParsedCertificate> ParsedCertificate::CreateInternal(
&result->subject_alt_names_extension_)) {
// RFC 5280 section 4.2.1.6:
// SubjectAltName ::= GeneralNames
- result->subject_alt_names_ = GeneralNames::CreateFromDer(
- result->subject_alt_names_extension_.value);
+ result->subject_alt_names_ =
+ GeneralNames::Create(result->subject_alt_names_extension_.value);
if (!result->subject_alt_names_)
return nullptr;
// RFC 5280 section 4.1.2.6:
@@ -174,7 +174,7 @@ scoped_refptr<ParsedCertificate> ParsedCertificate::CreateInternal(
if (ConsumeExtension(NameConstraintsOid(), &result->unparsed_extensions_,
&extension)) {
result->name_constraints_ =
- NameConstraints::CreateFromDer(extension.value, extension.critical);
+ NameConstraints::Create(extension.value, extension.critical);
if (!result->name_constraints_)
return nullptr;
}
« no previous file with comments | « net/cert/internal/parse_certificate_fuzzer.cc ('k') | net/cert/x509_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698