Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 23533066: Move the GL shader compilation step into GrGLShaderBuilder (Closed)

Created:
7 years, 3 months ago by Chris Dalton
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Move the GL shader compilation step into GrGLShaderBuilder Moves the compilation step and a few other blocks of code from GrGLProgram to GrGLShaderBuilder. This way GrGLProgram doesn't have to know whether or not there is a vertex shader. Committed: http://code.google.com/p/skia/source/detail?r=11523

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -544 lines) Patch
M src/gpu/gl/GrGLProgram.h View 2 chunks +1 line, -19 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 11 chunks +13 lines, -369 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 chunk +0 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 11 chunks +50 lines, -48 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 20 chunks +355 lines, -82 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Chris Dalton
7 years, 3 months ago (2013-09-18 19:19:02 UTC) #1
bsalomon
It seems like a step in the right direction. Eventually I'd like the builder to ...
7 years, 3 months ago (2013-09-18 20:03:25 UTC) #2
Chris Dalton
BTW, this depends on https://codereview.chromium.org/23464082/
7 years, 3 months ago (2013-09-18 20:17:07 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-09-30 15:15:19 UTC) #4
bsalomon
On 2013/09/18 20:17:07, Chris Dalton wrote: > BTW, this depends on https://codereview.chromium.org/23464082/ lgtm
7 years, 2 months ago (2013-09-30 15:15:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23533066/6002
7 years, 2 months ago (2013-09-30 15:15:41 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 15:30:41 UTC) #7
Message was sent while issue was closed.
Change committed as 11523

Powered by Google App Engine
This is Rietveld 408576698