Source/wtf/OwnPtrCommon.h - Issue 23531003: Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/OwnPtrCommon.h

Issue 23531003: Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Keeping macros in TypeTraits.h Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/wtf/OwnPtrCommon.h

diff --git a/Source/wtf/OwnPtrCommon.h b/Source/wtf/OwnPtrCommon.h

index 6aada1f80a0e087531aa6db185f29d6f9d68fb8d..b33c3b221900b837419ec7009b19261eaaf6b2eb 100644

--- a/Source/wtf/OwnPtrCommon.h

+++ b/Source/wtf/OwnPtrCommon.h

@@ -28,6 +28,11 @@

#ifndef WTF_OwnPtrCommon_h

#define WTF_OwnPtrCommon_h

+#define EnsureOwnPtrConvertibleArgDecl(From, To) \

+ EnsurePtrConvertibleArgDecl(typename RemovePointer<From>::Type, typename RemovePointer<To>::Type)

+#define EnsureOwnPtrConvertibleArgDefn(From, To) \

+ EnsurePtrConvertibleArgDefn(typename RemovePointer<From>::Type, typename RemovePointer<To>::Type)

kouhei (in TOK) 2013/09/02 12:17:24 I think we should use the macro in TypeTraits.h.

#if OS(WINDOWS)

typedef struct HBITMAP__* HBITMAP;

typedef struct HBRUSH__* HBRUSH;

« no previous file with comments | « Source/wtf/OwnPtr.h ('k') | Source/wtf/PassOwnArrayPtr.h » ('j') | no next file with comments »