Source/wtf/PassOwnArrayPtr.h - Issue 23531003: Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/PassOwnArrayPtr.h

Issue 23531003: Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Keeping macros in TypeTraits.h Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/wtf/PassOwnArrayPtr.h

diff --git a/Source/wtf/PassOwnArrayPtr.h b/Source/wtf/PassOwnArrayPtr.h

index 724dba3bf41e4a4dffd17e97d54560ac9a6d92d1..124fdb43f424d18cbaa774b8311d51ca132dd1e4 100644

--- a/Source/wtf/PassOwnArrayPtr.h

+++ b/Source/wtf/PassOwnArrayPtr.h

@@ -49,7 +49,7 @@ public:

// a const PassOwnArrayPtr. However, it makes it much easier to work with PassOwnArrayPtr

// temporaries, and we don't have a need to use real const PassOwnArrayPtrs anyway.

PassOwnArrayPtr(const PassOwnArrayPtr& o) : m_ptr(o.leakPtr()) { }

- template<typename U> PassOwnArrayPtr(const PassOwnArrayPtr<U>& o) : m_ptr(o.leakPtr()) { }

+ template<typename U> PassOwnArrayPtr(const PassOwnArrayPtr<U>& o, EnsurePtrConvertibleArgDecl(U, T)) : m_ptr(o.leakPtr()) { }

~PassOwnArrayPtr() { deleteOwnedArrayPtr(m_ptr); }

« Source/wtf/OwnPtrCommon.h ('K') | « Source/wtf/OwnPtrCommon.h ('k') | Source/wtf/PassOwnPtr.h » ('j') | no next file with comments »