Chromium Code Reviews Chromium Code Reviews
Issue 23531003:
Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2009 Apple Inc. All rights reserved. | 2 * Copyright (C) 2009 Apple Inc. All rights reserved. |
| 3 * Copyright (C) 2009 Torch Mobile, Inc. | 3 * Copyright (C) 2009 Torch Mobile, Inc. |
| 4 * Copyright (C) 2010 Company 100 Inc. | 4 * Copyright (C) 2010 Company 100 Inc. |
| 5 * | 5 * |
| 6 * Redistribution and use in source and binary forms, with or without | 6 * Redistribution and use in source and binary forms, with or without |
| 7 * modification, are permitted provided that the following conditions | 7 * modification, are permitted provided that the following conditions |
| 8 * are met: | 8 * are met: |
| 9 * 1. Redistributions of source code must retain the above copyright | 9 * 1. Redistributions of source code must retain the above copyright |
| 10 * notice, this list of conditions and the following disclaimer. | 10 * notice, this list of conditions and the following disclaimer. |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | 21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR |
| 22 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | 22 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY |
| 23 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 23 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 24 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 24 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 25 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 25 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 26 */ | 26 */ |
| 27 | 27 |
| 28 #ifndef WTF_OwnPtrCommon_h | 28 #ifndef WTF_OwnPtrCommon_h |
| 29 #define WTF_OwnPtrCommon_h | 29 #define WTF_OwnPtrCommon_h |
| 30 | 30 |
| 31 #define EnsureOwnPtrConvertibleArgDecl(From, To) \ | |
| 32 EnsurePtrConvertibleArgDecl(typename RemovePointer<From>::Type, typename Rem ovePointer<To>::Type) | |
| 33 #define EnsureOwnPtrConvertibleArgDefn(From, To) \ | |
| 34 EnsurePtrConvertibleArgDefn(typename RemovePointer<From>::Type, typename Rem ovePointer<To>::Type) | |
|
kouhei (in TOK)
2013/09/02 12:17:24
I think we should use the macro in TypeTraits.h.
| |
| 35 | |
| 31 #if OS(WINDOWS) | 36 #if OS(WINDOWS) |
| 32 typedef struct HBITMAP__* HBITMAP; | 37 typedef struct HBITMAP__* HBITMAP; |
| 33 typedef struct HBRUSH__* HBRUSH; | 38 typedef struct HBRUSH__* HBRUSH; |
| 34 typedef struct HDC__* HDC; | 39 typedef struct HDC__* HDC; |
| 35 typedef struct HFONT__* HFONT; | 40 typedef struct HFONT__* HFONT; |
| 36 typedef struct HPALETTE__* HPALETTE; | 41 typedef struct HPALETTE__* HPALETTE; |
| 37 typedef struct HPEN__* HPEN; | 42 typedef struct HPEN__* HPEN; |
| 38 typedef struct HRGN__* HRGN; | 43 typedef struct HRGN__* HRGN; |
| 39 #endif | 44 #endif |
| 40 | 45 |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 53 void deleteOwnedPtr(HDC); | 58 void deleteOwnedPtr(HDC); |
| 54 void deleteOwnedPtr(HFONT); | 59 void deleteOwnedPtr(HFONT); |
| 55 void deleteOwnedPtr(HPALETTE); | 60 void deleteOwnedPtr(HPALETTE); |
| 56 void deleteOwnedPtr(HPEN); | 61 void deleteOwnedPtr(HPEN); |
| 57 void deleteOwnedPtr(HRGN); | 62 void deleteOwnedPtr(HRGN); |
| 58 #endif | 63 #endif |
| 59 | 64 |
| 60 } // namespace WTF | 65 } // namespace WTF |
| 61 | 66 |
| 62 #endif // WTF_OwnPtrCommon_h | 67 #endif // WTF_OwnPtrCommon_h |
| OLD | NEW |
