content/browser/browser_plugin/browser_plugin_embedder.cc - Issue 23530029: Support webview tag when the container extension is embedded in a webUI

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 23530029: Support webview tag when the container extension is embedded in a webUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed unnecessary lines from document_custom_bindings Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/extensions/document_custom_bindings.cc ('k') | content/browser/browser_plugin/browser_plugin_guest_manager.cc » ('j') | content/browser/web_contents/render_view_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_embedder.cc

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc

index 4a06aca32c9218af34b9c70c0184c66aeca76b75..7698a91cef682a2394b27d1023c8261777907d8d 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.cc

+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -187,6 +187,7 @@ void BrowserPluginEmbedder::OnAttach(

GetContentClient()->browser()->GuestWebContentsAttached(

guest->GetWebContents(),

web_contents(),

+ GURL(params.embedder_frame_url),

Charlie Reis 2013/09/13 21:17:24 URLs received from the renderer should be passed t

guohui 2013/09/16 22:27:02 Done.

Charlie Reis 2013/09/18 17:42:23 Great, thanks!

guohui 2013/09/19 13:48:41 Done.

extra_params);

guest->Attach(static_cast<WebContentsImpl*>(web_contents()), params);

return;

@@ -201,6 +202,7 @@ void BrowserPluginEmbedder::OnAttach(

GetContentClient()->browser()->GuestWebContentsAttached(

guest->GetWebContents(),

web_contents(),

+ GURL(params.embedder_frame_url),

extra_params);

guest->Initialize(static_cast<WebContentsImpl*>(web_contents()), params);

}