Support webview tag when the container extension is embedded in a webUI

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include "base/values.h"
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/browser_plugin/browser_plugin_guest_manager.h"
 #include "content/browser/browser_plugin/browser_plugin_host_factory.h"
@@ skipping 169 matching lines @@
 
   if (guest) {
     // There is an implicit order expectation here:
     // 1. The content embedder is made aware of the attachment.
     // 2. BrowserPluginGuest::Attach is called.
     // 3. The content embedder issues queued events if any that happened
     //    prior to attachment.
     GetContentClient()->browser()->GuestWebContentsAttached(
         guest->GetWebContents(),
         web_contents(),
+        GURL(params.embedder_frame_url),

[Charlie Reis, 2013/09/13 21:17:24]

URLs received from the renderer should be passed through
RenderViewHost::FilterURL, to prevent the renderer process from lying to gain
more privileges.  |empty_allowed| should be false for this context.

Look around for examples of validated_params and FilterURL in other files. 
(Fady, it looks like we may need to do this to BrowserPlugin messages more
generally.)

[guohui, 2013/09/16 22:27:02]

Done.

[Charlie Reis, 2013/09/18 17:42:23]

Great, thanks!

[guohui, 2013/09/19 13:48:41]

Done.

         extra_params);
     guest->Attach(static_cast<WebContentsImpl*>(web_contents()), params);
     return;
   }
 
   scoped_ptr<base::DictionaryValue> copy_extra_params(extra_params.DeepCopy());
   guest = GetBrowserPluginGuestManager()->CreateGuest(
       web_contents()->GetSiteInstance(),
       instance_id, params,
       copy_extra_params.Pass());
   if (guest) {
     GetContentClient()->browser()->GuestWebContentsAttached(
         guest->GetWebContents(),
         web_contents(),
+        GURL(params.embedder_frame_url),
         extra_params);
     guest->Initialize(static_cast<WebContentsImpl*>(web_contents()), params);
   }
 }
 
 void BrowserPluginEmbedder::OnPluginAtPositionResponse(
     int instance_id, int request_id, const gfx::Point& position) {
   const std::map<int, WebContents::GetRenderViewHostCallback>::iterator
       callback_iter = pending_get_render_view_callbacks_.find(request_id);
   if (callback_iter == pending_get_render_view_callbacks_.end())
     return;
 
   RenderViewHost* render_view_host;
   BrowserPluginGuest* guest = NULL;
   if (instance_id != browser_plugin::kInstanceIDNone) {
     guest = GetBrowserPluginGuestManager()->GetGuestByInstanceID(
                 instance_id, web_contents()->GetRenderProcessHost()->GetID());
   }
 
   if (guest)
     render_view_host = guest->GetWebContents()->GetRenderViewHost();
   else  // No plugin, use embedder's RenderViewHost.
     render_view_host = web_contents()->GetRenderViewHost();
 
   callback_iter->second.Run(render_view_host, position.x(), position.y());
   pending_get_render_view_callbacks_.erase(callback_iter);
 }
 
 }  // namespace content