Support webview tag when the container extension is embedded in a webUI

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 7f4bfe242cfb23406a98e1f18063aad9f4542d68..4d11d58ae46311866446799b2a37c893d1874045 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -415,9 +415,6 @@ const Extension* ChromeContentRendererClient::GetExtension(
     return NULL;
 
   const std::string extension_id = origin.host().utf8().data();
-  if (!extension_dispatcher_->IsExtensionActive(extension_id))

[Charlie Reis, 2013/09/13 21:17:24]

Why is this being removed?

[guohui, 2013/09/16 22:27:02]

This check requires the extension to be active in the current process, meaning
that the extension must be loaded in the top window. We need to remove this
check to support webview in an iframed extension.

Also this method is only called to check for browser plugin support, thus it
should have no side effect.

[Charlie Reis, 2013/09/18 17:42:23]

This is a very general sounding method (GetExtension), so it has implications
for future callers, not just the current ones.  To remove any ambiguity about
what it does, let's rename it to GetExtensionByOrigin, and let's add a comment
to the declaration saying that it doesn't require the current process to be an
extension process.

[guohui, 2013/09/19 13:48:41]

Done.

-    return NULL;
-
   return extension_dispatcher_->extensions()->GetByID(extension_id);
 }