Support webview tag when the container extension is embedded in a webUI

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
@@ skipping 397 matching lines @@
 std::string ChromeContentRendererClient::GetDefaultEncoding() {
   return l10n_util::GetStringUTF8(IDS_DEFAULT_ENCODING);
 }
 
 const Extension* ChromeContentRendererClient::GetExtension(
     const WebSecurityOrigin& origin) const {
   if (!EqualsASCII(origin.protocol(), extensions::kExtensionScheme))
     return NULL;
 
   const std::string extension_id = origin.host().utf8().data();
-  if (!extension_dispatcher_->IsExtensionActive(extension_id))

[Charlie Reis, 2013/09/13 21:17:24]

Why is this being removed?

[guohui, 2013/09/16 22:27:02]

This check requires the extension to be active in the current process, meaning
that the extension must be loaded in the top window. We need to remove this
check to support webview in an iframed extension.

Also this method is only called to check for browser plugin support, thus it
should have no side effect.

[Charlie Reis, 2013/09/18 17:42:23]

This is a very general sounding method (GetExtension), so it has implications
for future callers, not just the current ones.  To remove any ambiguity about
what it does, let's rename it to GetExtensionByOrigin, and let's add a comment
to the declaration saying that it doesn't require the current process to be an
extension process.

[guohui, 2013/09/19 13:48:41]

Done.

-    return NULL;
-
   return extension_dispatcher_->extensions()->GetByID(extension_id);
 }
 
 bool ChromeContentRendererClient::OverrideCreatePlugin(
     content::RenderView* render_view,
     WebFrame* frame,
     const WebPluginParams& params,
     WebPlugin** plugin) {
   std::string orig_mime_type = params.mimeType.utf8();
   if (orig_mime_type == content::kBrowserPluginMimeType) {
@@ skipping 878 matching lines @@
   // SiteIsolationPolicy is off by default. We would like to activate cross-site
   // document blocking (for UMA data collection) for normal renderer processes
   // running a normal web page from the Internet. We only turn on
   // SiteIsolationPolicy for a renderer process that does not have the extension
   // flag on.
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   return !command_line->HasSwitch(switches::kExtensionProcess);
 }
 
 }  // namespace chrome