chrome/renderer/extensions/document_custom_bindings.cc - Issue 23530029: Support webview tag when the container extension is embedded in a webUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/document_custom_bindings.cc

Issue 23530029: Support webview tag when the container extension is embedded in a webUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fady's comment addressed Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/document_custom_bindings.cc

diff --git a/chrome/renderer/extensions/document_custom_bindings.cc b/chrome/renderer/extensions/document_custom_bindings.cc

index 36406c234bf8b6af81815dfeeed651caca2634c5..85ac519ba2e485e53cf32014d1b9749c82d090c1 100644

--- a/chrome/renderer/extensions/document_custom_bindings.cc

+++ b/chrome/renderer/extensions/document_custom_bindings.cc

@@ -7,6 +7,7 @@

#include <string>

#include "base/bind.h"

+#include "chrome/renderer/extensions/chrome_v8_context.h"

#include "content/public/renderer/render_view.h"

Fady Samuel 2013/09/12 22:46:46 This probably not necessary.

guohui 2013/09/13 00:04:02 Thanks for spotting this! Done.

#include "third_party/WebKit/public/web/WebDocument.h"

#include "third_party/WebKit/public/web/WebFrame.h"

@@ -45,7 +46,7 @@ void DocumentCustomBindings::RegisterElement(

v8::Local<v8::Object> options = args[1]->ToObject();

WebKit::WebExceptionCode ec = 0;

- WebKit::WebDocument document = web_view->mainFrame()->document();

+ WebKit::WebDocument document = context()->web_frame()->document();

v8::Handle<v8::Value> constructor =

document.registerEmbedderCustomElement(

WebKit::WebString::fromUTF8(element_name), options, ec);