Support webview tag when the container extension is embedded in a webUI

chrome/renderer/extensions/document_custom_bindings.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/document_custom_bindings.h"
 
 #include <string>
 
 #include "base/bind.h"
+#include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "content/public/renderer/render_view.h"

[Fady Samuel, 2013/09/12 22:46:46]

This probably not necessary.

[guohui, 2013/09/13 00:04:02]

Thanks for spotting this!

Done.

 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebView.h"

[Fady Samuel, 2013/09/12 22:46:46]

This line might not be necessary.

[guohui, 2013/09/13 00:04:02]

Done.

 #include "v8/include/v8.h"
 
 namespace extensions {
 
 DocumentCustomBindings::DocumentCustomBindings(
     Dispatcher* dispatcher, ChromeV8Context* context)
     : ChromeV8Extension(dispatcher, context) {
   RouteFunction("RegisterElement",
       base::Bind(&DocumentCustomBindings::RegisterElement,
                  base::Unretained(this)));
 }
 
 // Attach an event name to an object.
 void DocumentCustomBindings::RegisterElement(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   content::RenderView* render_view = GetRenderView();

[Fady Samuel, 2013/09/12 22:46:46]

These three lines are no longer necessary.

   if (!render_view) {
     return;
   }
 
   WebKit::WebView* web_view = render_view->GetWebView();

[Fady Samuel, 2013/09/12 22:46:46]

These 4 lines are no longer necessary.

All the changes in this file can probably be done in a separate CL. Nothing here
is controversial. 

[guohui, 2013/09/13 00:04:02]

Changes in this file are an integral part of the whole plan to support webview
in an iframed extension.  Without other changes in this CL, they make no
difference, since otherwise a webview embedder must always be the main frame.

   if (!web_view) {
     return;
   }
 
   if (args.Length() != 2 || !args[0]->IsString() || !args[1]->IsObject()) {
     NOTREACHED();
     return;
   }
 
   std::string element_name(*v8::String::AsciiValue(args[0]));
   v8::Local<v8::Object> options = args[1]->ToObject();
 
   WebKit::WebExceptionCode ec = 0;
-  WebKit::WebDocument document = web_view->mainFrame()->document();
+  WebKit::WebDocument document = context()->web_frame()->document();
   v8::Handle<v8::Value> constructor =
       document.registerEmbedderCustomElement(
           WebKit::WebString::fromUTF8(element_name), options, ec);
   args.GetReturnValue().Set(constructor);
 }
 
 }  // namespace extensions