content/browser/browser_plugin/browser_plugin_embedder.cc - Issue 23530029: Support webview tag when the container extension is embedded in a webUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 23530029: Support webview tag when the container extension is embedded in a webUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fady's comment addressed Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/document_custom_bindings.cc ('K') | « chrome/renderer/extensions/document_custom_bindings.cc ('k') | content/browser/browser_plugin/browser_plugin_guest_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_embedder.cc

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc

index 4a06aca32c9218af34b9c70c0184c66aeca76b75..7698a91cef682a2394b27d1023c8261777907d8d 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.cc

+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -187,6 +187,7 @@ void BrowserPluginEmbedder::OnAttach(

GetContentClient()->browser()->GuestWebContentsAttached(

guest->GetWebContents(),

web_contents(),

+ GURL(params.embedder_frame_url),

extra_params);

guest->Attach(static_cast<WebContentsImpl*>(web_contents()), params);

return;

@@ -201,6 +202,7 @@ void BrowserPluginEmbedder::OnAttach(

GetContentClient()->browser()->GuestWebContentsAttached(

guest->GetWebContents(),

web_contents(),

+ GURL(params.embedder_frame_url),

extra_params);

guest->Initialize(static_cast<WebContentsImpl*>(web_contents()), params);

}