Method to call a method with an entry based on its url

Method to call a method with an entry based on its url

This CL adds a method to the reading list model to call a callback with the
entry associated with the url passed as argument.

BUG=none

Committed: https://crrev.com/6284f3833dd237a48895403f48dec88f1e055417
Cr-Commit-Position: refs/heads/master@{#420352}

[gambard, 2016-09-20 08:52:21]

gambard@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[gambard, 2016-09-20 08:52:22]

PTAL.

[Olivier, 2016-09-20 11:13:44]

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_model.h:65:
base::Callback<void(const ReadingListEntry&)> callback) const = 0;
we could add a bool read parameter.
wdyt?

In comment, add synchronously

[Olivier, 2016-09-20 11:14:25]

Can you add unittests?

[gambard, 2016-09-20 11:27:33]

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_model.h:65:
base::Callback<void(const ReadingListEntry&)> callback) const = 0;
On 2016/09/20 11:13:44, Olivier Robin wrote:
> we could add a bool read parameter.
> wdyt?
> 
> In comment, add synchronously
> 

I don't see the use case, can you clarify?
The behavior would be: if the bool is true look for an entry in read, if false
look for it everywhere?

[Olivier, 2016-09-20 11:29:50]

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_model.h:65:
base::Callback<void(const ReadingListEntry&)> callback) const = 0;
On 2016/09/20 11:27:33, gambard wrote:
> On 2016/09/20 11:13:44, Olivier Robin wrote:
> > we could add a bool read parameter.
> > wdyt?
> > 
> > In comment, add synchronously
> > 
> 
> I don't see the use case, can you clarify?
> The behavior would be: if the bool is true look for an entry in read, if false
> look for it everywhere?

The bool parameter is in the callback parameter, not in the method.
The model tells the caller if the found entry is read or not.

[gambard, 2016-09-20 12:07:10]

Thanks, PTAL.

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/reading_list_model.h:65:
base::Callback<void(const ReadingListEntry&)> callback) const = 0;
On 2016/09/20 11:29:50, Olivier Robin wrote:
> On 2016/09/20 11:27:33, gambard wrote:
> > On 2016/09/20 11:13:44, Olivier Robin wrote:
> > > we could add a bool read parameter.
> > > wdyt?
> > > 
> > > In comment, add synchronously
> > > 
> > 
> > I don't see the use case, can you clarify?
> > The behavior would be: if the bool is true look for an entry in read, if
false
> > look for it everywhere?
> 
> The bool parameter is in the callback parameter, not in the method.
> The model tells the caller if the found entry is read or not.

For now I don't see where this could be used in our code. Unless you think it is
a valuable addition, I will keep this in mind and add it only if I find a use
for it.

[Olivier, 2016-09-22 15:28:27]

lgtm

[gambard, 2016-09-22 15:28:50]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2016-09-22 15:29:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 15:38:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 15:40:31]

Description was changed from

==========
Method to call a method with an entry based on its url

This CL adds a method to the reading list model to call a callback with the
entry associated with the url passed as argument.

BUG=none
==========

to

==========
Method to call a method with an entry based on its url

This CL adds a method to the reading list model to call a callback with the
entry associated with the url passed as argument.

BUG=none

Committed: https://crrev.com/6284f3833dd237a48895403f48dec88f1e055417
Cr-Commit-Position: refs/heads/master@{#420352}
==========

[commit-bot: I haz the power, 2016-09-22 15:40:32]

Patchset 2 (id:??) landed as
https://crrev.com/6284f3833dd237a48895403f48dec88f1e055417
Cr-Commit-Position: refs/heads/master@{#420352}