Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2352973002: Method to call a method with an entry based on its url (Closed)

Created:
4 years, 3 months ago by gambard
Modified:
4 years, 3 months ago
Reviewers:
Olivier
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Method to call a method with an entry based on its url This CL adds a method to the reading list model to call a callback with the entry associated with the url passed as argument. BUG=none Committed: https://crrev.com/6284f3833dd237a48895403f48dec88f1e055417 Cr-Commit-Position: refs/heads/master@{#420352}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -1 line) Patch
M ios/chrome/browser/reading_list/reading_list_model.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_impl.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_unittest.cc View 1 4 chunks +68 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (3 generated)
gambard
PTAL.
4 years, 3 months ago (2016-09-20 08:52:22 UTC) #2
Olivier
https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h File ios/chrome/browser/reading_list/reading_list_model.h (right): https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h#newcode65 ios/chrome/browser/reading_list/reading_list_model.h:65: base::Callback<void(const ReadingListEntry&)> callback) const = 0; we could add ...
4 years, 3 months ago (2016-09-20 11:13:44 UTC) #3
Olivier
Can you add unittests?
4 years, 3 months ago (2016-09-20 11:14:25 UTC) #4
gambard
https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h File ios/chrome/browser/reading_list/reading_list_model.h (right): https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h#newcode65 ios/chrome/browser/reading_list/reading_list_model.h:65: base::Callback<void(const ReadingListEntry&)> callback) const = 0; On 2016/09/20 11:13:44, ...
4 years, 3 months ago (2016-09-20 11:27:33 UTC) #5
Olivier
https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h File ios/chrome/browser/reading_list/reading_list_model.h (right): https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h#newcode65 ios/chrome/browser/reading_list/reading_list_model.h:65: base::Callback<void(const ReadingListEntry&)> callback) const = 0; On 2016/09/20 11:27:33, ...
4 years, 3 months ago (2016-09-20 11:29:50 UTC) #6
gambard
Thanks, PTAL. https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h File ios/chrome/browser/reading_list/reading_list_model.h (right): https://codereview.chromium.org/2352973002/diff/1/ios/chrome/browser/reading_list/reading_list_model.h#newcode65 ios/chrome/browser/reading_list/reading_list_model.h:65: base::Callback<void(const ReadingListEntry&)> callback) const = 0; On ...
4 years, 3 months ago (2016-09-20 12:07:10 UTC) #7
Olivier
lgtm
4 years, 3 months ago (2016-09-22 15:28:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352973002/20001
4 years, 3 months ago (2016-09-22 15:29:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 15:38:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:40:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6284f3833dd237a48895403f48dec88f1e055417
Cr-Commit-Position: refs/heads/master@{#420352}

Powered by Google App Engine
This is Rietveld 408576698