Method to call a method with an entry based on its url

ios/chrome/browser/reading_list/reading_list_model.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_H_
 #define IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
+#include "base/callback.h"
 #include "base/observer_list.h"
 #include "ios/chrome/browser/reading_list/reading_list_entry.h"
 #include "ios/chrome/browser/reading_list/reading_list_model_observer.h"
 
 class GURL;
 class ReadingListModel;
 
 namespace ios {
 class ChromeBrowserState;
 }
@@ skipping 27 matching lines @@
   // Returns true if there are entries in the model that were not seen by the
   // user yet. Reset to true when new unread entries are added. Reset to false
   // when ResetUnseenEntries is called.
   virtual bool HasUnseenEntries() const = 0;
   virtual void ResetUnseenEntries() = 0;
 
   // Returns a specific entry.
   virtual const ReadingListEntry& GetUnreadEntryAtIndex(size_t index) const = 0;
   virtual const ReadingListEntry& GetReadEntryAtIndex(size_t index) const = 0;
 
+  // Calls the |callback| with entry associated with this |url|. Does nothing if
+  // there is no entry associated.
+  // Returns whether the callback has been called.
+  virtual bool CallbackEntryURL(
+      const GURL& url,
+      base::Callback<void(const ReadingListEntry&)> callback) const = 0;

[Olivier, 2016/09/20 11:13:44]

we could add a bool read parameter.
wdyt?

In comment, add synchronously

[gambard, 2016/09/20 11:27:33]

I don't see the use case, can you clarify?
The behavior would be: if the bool is true look for an entry in read, if false
look for it everywhere?

[Olivier, 2016/09/20 11:29:50]

The bool parameter is in the callback parameter, not in the method.
The model tells the caller if the found entry is read or not.

[gambard, 2016/09/20 12:07:10]

For now I don't see where this could be used in our code. Unless you think it is
a valuable addition, I will keep this in mind and add it only if I find a use
for it.

+
   // Adds |url| at the top of the unread entries, and removes entries with the
   // same |url| from everywhere else if they exist. The addition may be
   // asynchronous, and the data will be available only once the observers are
   // notified.
   virtual const ReadingListEntry& AddEntry(const GURL& url,
                                            const std::string& title) = 0;
 
   // Removes an entry. The removal may be asynchronous, and not happen
   // immediately.
   virtual void RemoveEntryByUrl(const GURL& url) = 0;
@@ skipping 41 matching lines @@
   // ReadingListBatchUpdateToken dtor.
   virtual void EndBatchUpdates();
 
  private:
   unsigned int current_batch_updates_count_;
 
   DISALLOW_COPY_AND_ASSIGN(ReadingListModel);
 };
 
 #endif  // IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_H_