Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2338133010: Add a TimeUntilNextTry to reading list (Closed)

Created:
4 years, 3 months ago by gambard
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a TimeUntilNextTry to reading list This CL adds a method to get the time delta until the next try for a reading list entry. This method is increased exponentially and automatically when the state changes from non-error to error. BUG=none Committed: https://crrev.com/cb3322bfbf31dac33a17266afca8c57a10c2a2e4 Cr-Commit-Position: refs/heads/master@{#420337}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 4

Patch Set 3 : Using time ticks instead of numbers #

Patch Set 4 : fixes #

Total comments: 3

Patch Set 5 : Use backoff entry #

Patch Set 6 : Fix comments and tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -11 lines) Patch
M ios/chrome/browser/reading_list/reading_list_entry.h View 1 2 3 4 5 4 chunks +13 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_entry.cc View 1 2 3 4 3 chunks +62 lines, -9 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_entry_unittest.cc View 1 2 3 4 5 2 chunks +76 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
gambard
PTAL.
4 years, 3 months ago (2016-09-16 13:40:00 UTC) #2
gambard
Closing this.
4 years, 3 months ago (2016-09-16 14:23:07 UTC) #3
noyau (Ping after 24h)
https://codereview.chromium.org/2338133010/diff/20001/ios/chrome/browser/reading_list/reading_list_entry.cc File ios/chrome/browser/reading_list/reading_list_entry.cc (right): https://codereview.chromium.org/2338133010/diff/20001/ios/chrome/browser/reading_list/reading_list_entry.cc#newcode71 ios/chrome/browser/reading_list/reading_list_entry.cc:71: distilled_state_ != WILL_RETRY && distilled_state_ != ERROR) This condition ...
4 years, 3 months ago (2016-09-16 14:25:13 UTC) #4
gambard
PTAL. Re-opening this. https://codereview.chromium.org/2338133010/diff/20001/ios/chrome/browser/reading_list/reading_list_entry.cc File ios/chrome/browser/reading_list/reading_list_entry.cc (right): https://codereview.chromium.org/2338133010/diff/20001/ios/chrome/browser/reading_list/reading_list_entry.cc#newcode71 ios/chrome/browser/reading_list/reading_list_entry.cc:71: distilled_state_ != WILL_RETRY && distilled_state_ != ...
4 years, 3 months ago (2016-09-19 09:08:10 UTC) #8
noyau (Ping after 24h)
https://codereview.chromium.org/2338133010/diff/50001/ios/chrome/browser/reading_list/reading_list_entry.cc File ios/chrome/browser/reading_list/reading_list_entry.cc (right): https://codereview.chromium.org/2338133010/diff/50001/ios/chrome/browser/reading_list/reading_list_entry.cc#newcode57 ios/chrome/browser/reading_list/reading_list_entry.cc:57: clock_ = other.clock_; On 2016/09/19 09:08:09, gambard wrote: > ...
4 years, 3 months ago (2016-09-19 09:19:54 UTC) #9
gambard
PTAL. https://codereview.chromium.org/2338133010/diff/50001/ios/chrome/browser/reading_list/reading_list_entry.cc File ios/chrome/browser/reading_list/reading_list_entry.cc (right): https://codereview.chromium.org/2338133010/diff/50001/ios/chrome/browser/reading_list/reading_list_entry.cc#newcode57 ios/chrome/browser/reading_list/reading_list_entry.cc:57: clock_ = other.clock_; On 2016/09/19 09:19:54, noyau wrote: ...
4 years, 3 months ago (2016-09-19 15:33:03 UTC) #10
noyau (Ping after 24h)
lgtm
4 years, 3 months ago (2016-09-19 15:40:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338133010/90001
4 years, 3 months ago (2016-09-22 14:49:25 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 3 months ago (2016-09-22 14:59:49 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:01:20 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/cb3322bfbf31dac33a17266afca8c57a10c2a2e4
Cr-Commit-Position: refs/heads/master@{#420337}

Powered by Google App Engine
This is Rietveld 408576698