Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2352823002: cc: Remove estimated parent draw time from renderer (Closed)

Created:
4 years, 3 months ago by enne (OOO)
Modified:
4 years, 3 months ago
Reviewers:
brianderson
CC:
cc-bugs_chromium.org, chromium-reviews, danakj, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove estimated parent draw time from renderer This is a display scheduler only concept now that unified begin frame is turned on. Renderers can just use the deadline passed to them from the top level begin frame source. This fixes a regression from https://codereview.chromium.org/2299003002 where Android was using the incorrect parent estimated draw time of none and so thought it had less time for frames than it did. R=brianderson@chromium.org BUG=646377 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/bfdea7f114aded7866981b8bfe3edd0c75155f12 Cr-Commit-Position: refs/heads/master@{#419617}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -47 lines) Patch
M cc/scheduler/scheduler.h View 3 chunks +0 lines, -7 lines 0 comments Download
M cc/scheduler/scheduler.cc View 5 chunks +5 lines, -16 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/proxy_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/proxy_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
enne (OOO)
4 years, 3 months ago (2016-09-19 18:45:27 UTC) #2
brianderson
lgtm!
4 years, 3 months ago (2016-09-19 20:47:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352823002/1
4 years, 3 months ago (2016-09-19 21:49:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/71511) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-19 21:51:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352823002/20001
4 years, 3 months ago (2016-09-19 21:57:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 01:09:45 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:11:35 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bfdea7f114aded7866981b8bfe3edd0c75155f12
Cr-Commit-Position: refs/heads/master@{#419617}

Powered by Google App Engine
This is Rietveld 408576698