Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2354673003: Add setting to disable latency recovery for tests (Closed)

Created:
4 years, 3 months ago by enne (OOO)
Modified:
4 years, 3 months ago
Reviewers:
brianderson
CC:
cc-bugs_chromium.org, chromium-reviews, danakj, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add setting to disable latency recovery for tests The scheduler uses timing history (and other inputs) to decide if it should try to recover latency. This makes some tests dependent on timing in terms of whether the scheduler will ever send a begin frame (or not, if it's trying to recover main thread latency). In some cases, this also can cause a live lock in tests where the scheduler is waiting for activation to send a begin frame and the activation is waiting for a begin frame before it lets itself finish. This has been fixed in the past by just making the tests tick quicker, but that's not very future proof. So, in order to make cc tests more robust, add a setting that disables all latency recover in the scheduler. R=brianderson@chromium.org BUG=632544 Committed: https://crrev.com/eb16f56d14abc73321c5128b0374f94c747aa9db Cr-Commit-Position: refs/heads/master@{#419573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M cc/scheduler/scheduler.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/scheduler/scheduler_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
enne (OOO)
4 years, 3 months ago (2016-09-19 18:28:02 UTC) #3
brianderson
lgtm
4 years, 3 months ago (2016-09-19 20:50:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354673003/1
4 years, 3 months ago (2016-09-19 21:14:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 21:47:10 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:50:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb16f56d14abc73321c5128b0374f94c747aa9db
Cr-Commit-Position: refs/heads/master@{#419573}

Powered by Google App Engine
This is Rietveld 408576698