Remove external begin frame source parameter and settings

Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.

TBR=nyquist@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/2b0ad689e8ca3c18f83dd2e823940c9e422e44d2
Cr-Commit-Position: refs/heads/master@{#419935}

[enne (OOO), 2016-09-09 20:51:20]

Description was changed from

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.
==========

to

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-09-12 20:45:08]

Description was changed from

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-09-12 20:45:09]

enne@chromium.org changed reviewers:
+ danakj@chromium.org

[enne (OOO), 2016-09-19 20:14:41]

This is several patches down a dependency chain, but should be ready for review.
 So close!  T_T

[enne (OOO), 2016-09-20 17:07:30]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[enne (OOO), 2016-09-20 17:07:54]

enne@chromium.org changed reviewers:
+ nyquist@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:07:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-09-20 17:08:18]

+nyquist for blimp/ OWNERS

[commit-bot: I haz the power, 2016-09-20 18:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:03:45]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-09-20 18:19:21]

LGTM

https://codereview.chromium.org/2324273002/diff/20001/cc/test/layer_tree_test.cc
File cc/test/layer_tree_test.cc (left):

https://codereview.chromium.org/2324273002/diff/20001/cc/test/layer_tree_test...
cc/test/layer_tree_test.cc:26: #include
"cc/test/fake_external_begin_frame_source.h"
Can you move the impl of this to the one test that uses it now?

https://codereview.chromium.org/2324273002/diff/20001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (left):

https://codereview.chromium.org/2324273002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:86: // Visibility and CompositorFrameSink
-------------------------------
Did you mean to?

[enne (OOO), 2016-09-20 18:34:26]

https://codereview.chromium.org/2324273002/diff/20001/cc/test/layer_tree_test.cc
File cc/test/layer_tree_test.cc (left):

https://codereview.chromium.org/2324273002/diff/20001/cc/test/layer_tree_test...
cc/test/layer_tree_test.cc:26: #include
"cc/test/fake_external_begin_frame_source.h"
On 2016/09/20 at 18:19:21, danakj wrote:
> Can you move the impl of this to the one test that uses it now?

Will punt.  This is used in scheduler_unittest and display_scheduler_unittest. 
I think I can remove it from scheduler_unittest but that's a larger patch.  I'll
follow up and do that.

https://codereview.chromium.org/2324273002/diff/20001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (left):

https://codereview.chromium.org/2324273002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:86: // Visibility and CompositorFrameSink
-------------------------------
On 2016/09/20 at 18:19:21, danakj wrote:
> Did you mean to?

Ah, the rebasing on this patch was super rough.  Thanks for catching this.

[enne (OOO), 2016-09-20 18:49:15]

I'll just TBR=nyquist as it's just removing a setting that was already set by
default (and is also now always on).

[enne (OOO), 2016-09-20 18:49:26]

Description was changed from

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.

TBR=nyquist@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-09-20 18:49:28]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-09-20 18:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2324273002/#ps60001
(title: "Add back comment, remove more febfs includes")

[commit-bot: I haz the power, 2016-09-20 18:49:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:25:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2016-09-21 00:39:11]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:40:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 01:45:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-21 01:49:14]

Description was changed from

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.

TBR=nyquist@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove external begin frame source parameter and settings

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.

TBR=nyquist@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/2b0ad689e8ca3c18f83dd2e823940c9e422e44d2
Cr-Commit-Position: refs/heads/master@{#419935}
==========

[commit-bot: I haz the power, 2016-09-21 01:49:15]

Patchset 4 (id:??) landed as
https://crrev.com/2b0ad689e8ca3c18f83dd2e823940c9e422e44d2
Cr-Commit-Position: refs/heads/master@{#419935}