Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

third_party/WebKit/Source/core/editing/Editor.h

Index: third_party/WebKit/Source/core/editing/Editor.h
diff --git a/third_party/WebKit/Source/core/editing/Editor.h b/third_party/WebKit/Source/core/editing/Editor.h
index 03ec6ed68c5ac784424fe70a0d4f645ebfa31208..a43cd1c294ff87a8139b7272fb90237e741e237f 100644
--- a/third_party/WebKit/Source/core/editing/Editor.h
+++ b/third_party/WebKit/Source/core/editing/Editor.h
@@ -218,7 +218,6 @@ public:
     void computeAndSetTypingStyle(StylePropertySet*, InputEvent::InputType);
 
     IntRect firstRectForRange(const EphemeralRange&) const;

[tkent, 2016/09/23 05:32:14]

Now this function assumes up-to-date layout.  We should add a comment about it
to Editor.h, add DisallowTransitionScope to firstRectForRange(), add
DHECK(...frameView()->needsLayotu()) to firstRectForRange(), and/or add
DCHECK(...document().needsLayoutTreeUpdate()) to firstRectForRange().
We should have a consistent policy about how to enforce the assumption.

[Xiaocheng, 2016/09/23 05:54:44]

Done.
Yeah, we should...

-    IntRect firstRectForRange(const Range*) const;

[tkent, 2016/09/23 05:32:14]

Please mention this removal in the CL description.

[Xiaocheng, 2016/09/23 05:54:44]

Done.

 
     void respondToChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions);