Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

third_party/WebKit/Source/core/editing/Editor.h

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 199 matching lines @@
 
     Range* findStringAndScrollToVisible(const String&, Range*, FindOptions);
     Range* findRangeOfString(const String& target, const EphemeralRange& referenceRange, FindOptions);
     Range* findRangeOfString(const String& target, const EphemeralRangeInFlatTree& referenceRange, FindOptions);
 
     const VisibleSelection& mark() const; // Mark, to be used as emacs uses it.
     void setMark(const VisibleSelection&);
 
     void computeAndSetTypingStyle(StylePropertySet*, InputEvent::InputType);
 
     IntRect firstRectForRange(const EphemeralRange&) const;

[tkent, 2016/09/23 05:32:14]

Now this function assumes up-to-date layout.  We should add a comment about it
to Editor.h, add DisallowTransitionScope to firstRectForRange(), add
DHECK(...frameView()->needsLayotu()) to firstRectForRange(), and/or add
DCHECK(...document().needsLayoutTreeUpdate()) to firstRectForRange().
We should have a consistent policy about how to enforce the assumption.

[Xiaocheng, 2016/09/23 05:54:44]

Done.
Yeah, we should...

-    IntRect firstRectForRange(const Range*) const;

[tkent, 2016/09/23 05:32:14]

Please mention this removal in the CL description.

[Xiaocheng, 2016/09/23 05:54:44]

Done.

 
     void respondToChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions);
 
     bool markedTextMatchesAreHighlighted() const;
     void setMarkedTextMatchesAreHighlighted(bool);
 
     void replaceSelectionWithFragment(DocumentFragment*, bool selectReplacement, bool smartReplace, bool matchStyle);
     void replaceSelectionWithText(const String&, bool selectReplacement, bool smartReplace);
 
     // TODO(xiaochengh): Replace |bool| parameters by |enum|.
@@ skipping 81 matching lines @@
 
 inline bool Editor::markedTextMatchesAreHighlighted() const
 {
     return m_areMarkedTextMatchesHighlighted;
 }
 
 
 } // namespace blink
 
 #endif // Editor_h