third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2352763004: Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2352763004: Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange (Closed)

Patch Set: 201609231108 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/Editor.h ('K') | « third_party/WebKit/Source/core/editing/Editor.h ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 6a66aa9d0db49ff014f509bfa78e2cf6c5cc1c1c..17c94b6ac127b55321fde1054a4a479930420175 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1166,11 +1166,11 @@ IntRect Editor::firstRectForRange(const EphemeralRange& range) const

LayoutUnit extraWidthToEndOfLine;

DCHECK(range.isNotNull());

- IntRect startCaretRect = RenderedPosition(createVisiblePositionDeprecated(range.startPosition()).deepEquivalent(), TextAffinity::Downstream).absoluteRect(&extraWidthToEndOfLine);

+ IntRect startCaretRect = RenderedPosition(createVisiblePosition(range.startPosition()).deepEquivalent(), TextAffinity::Downstream).absoluteRect(&extraWidthToEndOfLine);

if (startCaretRect.isEmpty())

return IntRect();

- IntRect endCaretRect = RenderedPosition(createVisiblePositionDeprecated(range.endPosition()).deepEquivalent(), TextAffinity::Upstream).absoluteRect();

+ IntRect endCaretRect = RenderedPosition(createVisiblePosition(range.endPosition()).deepEquivalent(), TextAffinity::Upstream).absoluteRect();

if (endCaretRect.isEmpty())

return IntRect();

@@ -1189,12 +1189,6 @@ IntRect Editor::firstRectForRange(const EphemeralRange& range) const

startCaretRect.height());

}

-IntRect Editor::firstRectForRange(const Range* range) const

- DCHECK(range);

- return firstRectForRange(EphemeralRange(range));

void Editor::computeAndSetTypingStyle(StylePropertySet* style, InputEvent::InputType inputType)

{

if (!style || style->isEmpty()) {