Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2352713004: Added displayId to Gamepad (Closed)

Created:
4 years, 3 months ago by bajones
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added displayId to Gamepad Specced as part of the WebVR API to associate Gamepad devices with a headset when applicable. See: https://w3c.github.io/webvr/#interface-gamepad BUG=389343 Committed: https://crrev.com/3ee1b2d10a9e09f725b4121a6dd114c3cb43fcaf Cr-Commit-Position: refs/heads/master@{#419878}

Patch Set 1 #

Patch Set 2 : Re-upstream w/o webvr dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M ppapi/shared_impl/ppb_gamepad_shared.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/Gamepad.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/Gamepad.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/Gamepad.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebGamepad.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
bajones
Sorry for the rush of gamepad changes recently. This should be the last one for ...
4 years, 3 months ago (2016-09-20 17:13:02 UTC) #2
aelias_OOO_until_Jul13
public/ lgtm
4 years, 3 months ago (2016-09-20 21:07:54 UTC) #11
bbudge
ppapi lgtm
4 years, 3 months ago (2016-09-20 21:26:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352713004/20001
4 years, 3 months ago (2016-09-20 22:40:32 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 22:46:16 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:48:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ee1b2d10a9e09f725b4121a6dd114c3cb43fcaf
Cr-Commit-Position: refs/heads/master@{#419878}

Powered by Google App Engine
This is Rietveld 408576698