Add GetOutputStreamParameters, GetAssociatedOutputDeviceID to AudioManager.

Add GetOutputStreamParameters, GetAssociatedOutputDeviceID to AudioManager.
- GetOutputStreamParameters(device_id). Does the same thing as GetDefaultOutputStreamParameters except that it allows the caller to choose the device.
- GetAssociatedOutputDeviceID(input_device_id): Does a best effort dig to match an output device to an input device (both devices belong to the same audio card). This is useful for heuristic algorithms to distinguish headphones from webcams (w/mic).

GetOutputStreamParameters is fully implemented on Windows but works only for the default device on other platforms (same as GetDefaultOutputStreamParameters).
- This is OK for now since we don't rely on GetOutputStreamParameters yet.

Added implementation of GetAssociatedOutputDeviceID on Windows.
Default implementation of GetAssociatedOutputDeviceID just returns an empty string (i.e. assume the default output device).

Did a little bit of a cleanup in the WASAPI/CoreAudio implementation on Windows where we were doing the same operation unnecessarily often.

BUG=276894
R=henrika@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221182

[henrika (OOO until Aug 14), 2013-09-04 11:11:40]

Great stuff. I am glad that we implemented the core audio util; pretty handy in
situations like this.

LGTM w/ nits.

https://codereview.chromium.org/23523023/diff/1/media/audio/audio_manager.h
File media/audio/audio_manager.h (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/audio_manager.h#n...
media/audio/audio_manager.h:148: // Returns the output hardware audio parameters
for a specific output device.
Did you consider using only this method and use a special input string for
default instead of having to similar API:s? Breaks less code I guess.

https://codereview.chromium.org/23523023/diff/1/media/audio/audio_manager.h#n...
media/audio/audio_manager.h:164: virtual std::string
GetAssociatedOutputDeviceID(
Like the name Associated.

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_low_lat...
File media/audio/win/audio_low_latency_output_win.h (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_low_lat...
media/audio/win/audio_low_latency_output_win.h:152: // processing/mixing of
shared-mode streams for the default endpoint device.
Change comment since it states "default".

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_manager...
File media/audio/win/audio_manager_win.cc (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_manager...
media/audio/win/audio_manager_win.cc:371: const bool core_audio_supported =
CoreAudioUtil::IsSupported();
nice!

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_manager...
media/audio/win/audio_manager_win.cc:384: // TODO(crogers): tune these values
for best possible WebAudio
rtoy instead of crogers?

https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:306: device_name.unique_id =
GetDeviceID(device);
nice

https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.h (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.h:63: // if no such device exists or if the
default device has been disabled.
Nit, ...or no output devices exists.

[tommi (sloooow) - chröme, 2013-09-04 13:06:51]

Address comments

[tommi (sloooow) - chröme, 2013-09-04 13:06:54]

https://codereview.chromium.org/23523023/diff/1/media/audio/audio_manager.h
File media/audio/audio_manager.h (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/audio_manager.h#n...
media/audio/audio_manager.h:148: // Returns the output hardware audio parameters
for a specific output device.
On 2013/09/04 11:11:40, henrika wrote:
> Did you consider using only this method and use a special input string for
> default instead of having to similar API:s? Breaks less code I guess.

Yes, that's the goal but I decided not to remove the other method in this cl but
I plan on doing it later.

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_low_lat...
File media/audio/win/audio_low_latency_output_win.h (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_low_lat...
media/audio/win/audio_low_latency_output_win.h:152: // processing/mixing of
shared-mode streams for the default endpoint device.
On 2013/09/04 11:11:40, henrika wrote:
> Change comment since it states "default".

Done.

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_manager...
File media/audio/win/audio_manager_win.cc (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_manager...
media/audio/win/audio_manager_win.cc:384: // TODO(crogers): tune these values
for best possible WebAudio
On 2013/09/04 11:11:40, henrika wrote:
> rtoy instead of crogers?

Done.

https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.h (right):

https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.h:63: // if no such device exists or if the
default device has been disabled.
On 2013/09/04 11:11:40, henrika wrote:
> Nit, ...or no output devices exists.

The comment already says "or an empty string if no such device exists" so I
think that's covered :)

[henrika (OOO until Aug 14), 2013-09-04 13:20:16]

SGTM.


On Wed, Sep 4, 2013 at 3:06 PM, <tommi@chromium.org> wrote:

>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/audio_manager.h<https://codereview.chromium.org/23523023/diff/1/media/audio/audio_manager.h>
> File media/audio/audio_manager.h (right):
>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/audio_manager.h#**newcode148<https://codereview.chromium.org/23523023/diff/1/media/audio/audio_manager.h#newcode148>
> media/audio/audio_manager.h:**148: // Returns the output hardware audio
> parameters for a specific output device.
> On 2013/09/04 11:11:40, henrika wrote:
>
>> Did you consider using only this method and use a special input string
>>
> for
>
>> default instead of having to similar API:s? Breaks less code I guess.
>>
>
> Yes, that's the goal but I decided not to remove the other method in
> this cl but I plan on doing it later.
>
>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/win/audio_low_latency_**output_win.h<https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_low_latency_output_win.h>
> File media/audio/win/audio_low_**latency_output_win.h (right):
>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/win/audio_low_latency_**output_win.h#newcode152<https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_low_latency_output_win.h#newcode152>
> media/audio/win/audio_low_**latency_output_win.h:152: // processing/mixing
> of shared-mode streams for the default endpoint device.
> On 2013/09/04 11:11:40, henrika wrote:
>
>> Change comment since it states "default".
>>
>
> Done.
>
>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/win/audio_manager_win.cc<https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_manager_win.cc>
> File media/audio/win/audio_manager_**win.cc (right):
>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/win/audio_manager_win.**cc#newcode384<https://codereview.chromium.org/23523023/diff/1/media/audio/win/audio_manager_win.cc#newcode384>
> media/audio/win/audio_manager_**win.cc:384: // TODO(crogers): tune these
> values for best possible WebAudio
> On 2013/09/04 11:11:40, henrika wrote:
>
>> rtoy instead of crogers?
>>
>
> Done.
>
>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/win/core_audio_util_win.**h<https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_util_win.h>
> File media/audio/win/core_audio_**util_win.h (right):
>
> https://codereview.chromium.**org/23523023/diff/1/media/**
>
audio/win/core_audio_util_win.**h#newcode63<https://codereview.chromium.org/23523023/diff/1/media/audio/win/core_audio_util_win.h#newcode63>
> media/audio/win/core_audio_**util_win.h:63: // if no such device exists or
> if the default device has been disabled.
> On 2013/09/04 11:11:40, henrika wrote:
>
>> Nit, ...or no output devices exists.
>>
>
> The comment already says "or an empty string if no such device exists"
> so I think that's covered :)
>
>
https://codereview.chromium.**org/23523023/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tommi (sloooow) - chröme, 2013-09-04 13:25:45]

Committed patchset #2 manually as r221182 (presubmit successful).