Get rid of custom code for Document::createTouchList()

Get rid of custom code for Document::createTouchList()

Get rid of custom code for Document::createTouchList() now that the bindings
generator supports variadic methods.

One behavior change is that we now throw a TypeError if one of the given arguments
is not a Touch, instead of treating it as null. This behavior is however consistent
with Firefox Mobile and the specification:
https://dvcs.w3.org/hg/webevents/raw-file/v1/touchevents.html#idl-def-Document

R=haraken,arv
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157885

[haraken, 2013-09-16 13:01:21]

LGTM. Needs an approval from an API owner.

[do-not-use, 2013-09-16 13:02:21]

+tkent

[arv (Not doing code reviews), 2013-09-16 13:06:20]

https://codereview.chromium.org/23522051/diff/2/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/23522051/diff/2/Source/core/dom/Document.h#ne...
Source/core/dom/Document.h:975: PassRefPtr<TouchList>
createTouchList(Vector<RefPtr<Touch> >&) const;
Shouldn't this be const Vector& since createTouchList should not change the
vector?

[do-not-use, 2013-09-16 13:25:26]

https://codereview.chromium.org/23522051/diff/2/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/23522051/diff/2/Source/core/dom/Document.h#ne...
Source/core/dom/Document.h:975: PassRefPtr<TouchList>
createTouchList(Vector<RefPtr<Touch> >&) const;
On 2013/09/16 13:06:20, arv wrote:
> Shouldn't this be const Vector& since createTouchList should not change the
> vector?

Why shouldn't createTouchList() modify the Vector? The caller (generated
bindings) constructs the Vector especially for Document and does not use it
afterwards.

This reference is not const on purpose to avoid copying the Touch vector when
constructing the TouchList (I use Vector::swap()). If I don't do that then the
generated code will be slower than the custom one due the to extra Vector copy.

[arv (Not doing code reviews), 2013-09-16 13:47:10]

On 2013/09/16 13:25:26, Christophe Dumez wrote:
> https://codereview.chromium.org/23522051/diff/2/Source/core/dom/Document.h
> File Source/core/dom/Document.h (right):
> 
>
https://codereview.chromium.org/23522051/diff/2/Source/core/dom/Document.h#ne...
> Source/core/dom/Document.h:975: PassRefPtr<TouchList>
> createTouchList(Vector<RefPtr<Touch> >&) const;
> On 2013/09/16 13:06:20, arv wrote:
> > Shouldn't this be const Vector& since createTouchList should not change the
> > vector?
> 
> Why shouldn't createTouchList() modify the Vector? The caller (generated
> bindings) constructs the Vector especially for Document and does not use it
> afterwards.

Fair enough.

> This reference is not const on purpose to avoid copying the Touch vector when
> constructing the TouchList (I use Vector::swap()). If I don't do that then the
> generated code will be slower than the custom one due the to extra Vector
copy.

LGTM

[tkent, 2013-09-16 22:13:56]

behavior change lgtm.

[commit-bot: I haz the power, 2013-09-17 05:45:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23522051/2

[commit-bot: I haz the power, 2013-09-17 07:11:58]

Change committed as 157885