LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js - Issue 23522051: Get rid of custom code for Document::createTouchList()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js

Issue 23522051: Get rid of custom code for Document::createTouchList() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add missing references Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js ('k') | Source/bindings/v8/custom/V8DocumentCustom.cpp » ('j') | Source/core/dom/Document.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js

diff --git a/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js b/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js

index 5ac01a5c8756a65c8bfa6047b41b5ae90a0b87e7..4ab1e9ec3bf34d5d7a28b9aba5811eefcc0cd41a 100644

--- a/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js

+++ b/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js

@@ -1,19 +1,10 @@

description("This test ensures that WebKit doesn't crash when the document.createTouchList API is called with non-Touch parameters");

-shouldBeNull('document.createTouchList(document).item(0)');

-shouldBeNull('document.createTouchList({"a":1}).item(0)');

-shouldBeNull('document.createTouchList(new Array(5)).item(0)');

-shouldBeNull('document.createTouchList("string").item(0)');

-shouldBeNull('document.createTouchList(null).item(0)');

-shouldBeNull('document.createTouchList(undefined).item(0)');

-var t = document.createTouch(window, document.body, 12341, 60, 65, 100, 105);

-var t2 = document.createTouch(window, document.body, 12342, 50, 55, 115, 120);

-var tl = document.createTouchList(t, document, t2);

-shouldBe('tl.length', '3');

-shouldBeNonNull('tl.item(0)');

-shouldBeNull('tl.item(1)');

-shouldBeNonNull('tl.item(2)');

+shouldThrow('document.createTouchList(document).item(0)', '"TypeError: Type error"');

+shouldThrow('document.createTouchList({"a":1}).item(0)', '"TypeError: Type error"');

+shouldThrow('document.createTouchList(new Array(5)).item(0)', '"TypeError: Type error"');

+shouldThrow('document.createTouchList("string").item(0)', '"TypeError: Type error"');

+shouldThrow('document.createTouchList(null).item(0)', '"TypeError: Type error"');

+shouldThrow('document.createTouchList(undefined).item(0)', '"TypeError: Type error"');

isSuccessfullyParsed();