Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: Source/core/dom/Document.h

Issue 23522051: Get rid of custom code for Document::createTouchList() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add missing references Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/custom/V8DocumentCustom.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 954 matching lines...) Expand 10 before | Expand all | Expand 10 after
965 965
966 void webkitExitPointerLock(); 966 void webkitExitPointerLock();
967 Element* webkitPointerLockElement() const; 967 Element* webkitPointerLockElement() const;
968 968
969 // Used to allow element that loads data without going through a FrameLoader to delay the 'load' event. 969 // Used to allow element that loads data without going through a FrameLoader to delay the 'load' event.
970 void incrementLoadEventDelayCount() { ++m_loadEventDelayCount; } 970 void incrementLoadEventDelayCount() { ++m_loadEventDelayCount; }
971 void decrementLoadEventDelayCount(); 971 void decrementLoadEventDelayCount();
972 bool isDelayingLoadEvent() const { return m_loadEventDelayCount; } 972 bool isDelayingLoadEvent() const { return m_loadEventDelayCount; }
973 973
974 PassRefPtr<Touch> createTouch(DOMWindow*, EventTarget*, int identifier, int pageX, int pageY, int screenX, int screenY, int radiusX, int radiusY, float rota tionAngle, float force) const; 974 PassRefPtr<Touch> createTouch(DOMWindow*, EventTarget*, int identifier, int pageX, int pageY, int screenX, int screenY, int radiusX, int radiusY, float rota tionAngle, float force) const;
975 PassRefPtr<TouchList> createTouchList(Vector<RefPtr<Touch> >&) const;
arv (Not doing code reviews) 2013/09/16 13:06:20 Shouldn't this be const Vector& since createTouchL
do-not-use 2013/09/16 13:25:27 Why shouldn't createTouchList() modify the Vector?
975 976
976 const DocumentTiming* timing() const { return &m_documentTiming; } 977 const DocumentTiming* timing() const { return &m_documentTiming; }
977 978
978 int requestAnimationFrame(PassRefPtr<RequestAnimationFrameCallback>); 979 int requestAnimationFrame(PassRefPtr<RequestAnimationFrameCallback>);
979 void cancelAnimationFrame(int id); 980 void cancelAnimationFrame(int id);
980 void serviceScriptedAnimations(double monotonicAnimationStartTime); 981 void serviceScriptedAnimations(double monotonicAnimationStartTime);
981 982
982 virtual EventTarget* errorEventTarget(); 983 virtual EventTarget* errorEventTarget();
983 virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>); 984 virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>);
984 985
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 inline bool Node::isDocumentNode() const 1445 inline bool Node::isDocumentNode() const
1445 { 1446 {
1446 return this == documentInternal(); 1447 return this == documentInternal();
1447 } 1448 }
1448 1449
1449 Node* eventTargetNodeForDocument(Document*); 1450 Node* eventTargetNodeForDocument(Document*);
1450 1451
1451 } // namespace WebCore 1452 } // namespace WebCore
1452 1453
1453 #endif // Document_h 1454 #endif // Document_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8DocumentCustom.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698