Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2352013002: MidiManagerWinrt as base::FeatureList feature (Closed)

Created:
4 years, 3 months ago by Shao-Chuan Lee
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MidiManagerWinrt as base::FeatureList feature Now MidiManagerWinrt is available as a base::FeatureList feature instead of command-line switch. BUG=645403 Committed: https://crrev.com/64ee320eb5f9adb0281de97c0d4a17317327ad10 Cr-Commit-Position: refs/heads/master@{#420165}

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix #3 #

Patch Set 3 : fix histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M media/midi/midi_switches.h View 1 2 chunks +11 lines, -2 lines 0 comments Download
M media/midi/midi_switches.cc View 1 1 chunk +11 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
Shao-Chuan Lee
Maybe we don't want to merge this immediately. How about collecting usage statistics on Windows ...
4 years, 3 months ago (2016-09-20 08:45:07 UTC) #2
Takashi Toyoshima
https://codereview.chromium.org/2352013002/diff/1/media/midi/midi_features.cc File media/midi/midi_features.cc (right): https://codereview.chromium.org/2352013002/diff/1/media/midi/midi_features.cc#newcode11 media/midi/midi_features.cc:11: base::FEATURE_ENABLED_BY_DEFAULT}; The Feature API is used for a field ...
4 years, 3 months ago (2016-09-20 09:12:04 UTC) #3
Shao-Chuan Lee
https://codereview.chromium.org/2352013002/diff/1/media/midi/midi_features.cc File media/midi/midi_features.cc (right): https://codereview.chromium.org/2352013002/diff/1/media/midi/midi_features.cc#newcode11 media/midi/midi_features.cc:11: base::FEATURE_ENABLED_BY_DEFAULT}; On 2016/09/20 09:12:04, toyoshim wrote: > The Feature ...
4 years, 3 months ago (2016-09-20 09:57:27 UTC) #5
Takashi Toyoshima
lgtm for midi. Probably, it's better to ask a field trial team member. Let me ...
4 years, 3 months ago (2016-09-20 10:11:47 UTC) #6
Takashi Toyoshima
asvitkine@, we want to enable an experimental implementation for Canary and Dev to check stability. ...
4 years, 3 months ago (2016-09-20 10:18:16 UTC) #8
Alexei Svitkine (slow)
LGTM
4 years, 3 months ago (2016-09-20 14:48:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352013002/20001
4 years, 3 months ago (2016-09-20 14:52:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/296200)
4 years, 3 months ago (2016-09-20 16:11:04 UTC) #14
Shao-Chuan Lee
isherman@: PTAL at histograms.xml. Should I remove the previous entry for "use-winrt-midi-api"?
4 years, 3 months ago (2016-09-21 02:32:58 UTC) #16
Ilya Sherman
On 2016/09/21 02:32:58, Shao-Chuan Lee wrote: > isherman@: PTAL at histograms.xml. Should I remove the ...
4 years, 3 months ago (2016-09-21 21:17:08 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352013002/40001
4 years, 3 months ago (2016-09-21 21:17:57 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 21:26:24 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 21:28:04 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64ee320eb5f9adb0281de97c0d4a17317327ad10
Cr-Commit-Position: refs/heads/master@{#420165}

Powered by Google App Engine
This is Rietveld 408576698