media/midi/midi_features.cc - Issue 2352013002: MidiManagerWinrt as base::FeatureList feature

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/midi/midi_features.cc

Issue 2352013002: MidiManagerWinrt as base::FeatureList feature (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "media/midi/midi_features.h"

	6

	7 namespace features {

	8

	9 #if defined(OS_WIN)

	10 const base::Feature kUseWinrtMidiApi{"UseWinrtMidiApi",

	11 base::FEATURE_ENABLED_BY_DEFAULT};
	Takashi Toyoshima 2016/09/20 09:12:04 The Feature API is used for a field trial in gener The Feature API is used for a field trial in general, and there is a clear guideline, go/finch101. Generally speaking, flipping this to ENABLED_BY_DEFAULT is the last step of the feature launch process, and need to start from DISABLED_BY_DEFAULT, and enable it via server side configurations so that we can shutdown the feature safely. I don't think this change need a launch review, but it's better to follow the guideline just in case so to avoid unnecessary troubles. Shao-Chuan Lee 2016/09/20 09:57:27 Done. Show quoted text On 2016/09/20 09:12:04, toyoshim wrote: > The Feature API is used for a field trial in general, and there is a clear > guideline, go/finch101. > Generally speaking, flipping this to ENABLED_BY_DEFAULT is the last step of the > feature launch process, and need to start from DISABLED_BY_DEFAULT, and enable > it via server side configurations so that we can shutdown the feature safely. > > I don't think this change need a launch review, but it's better to follow the > guideline just in case so to avoid unnecessary troubles. Done.
	12 #endif

	13

	14 } // namespace features

OLD	NEW

« media/midi/midi_features.h ('K') | « media/midi/midi_features.h ('k') | media/midi/midi_manager_win.cc » ('j') | no next file with comments »