media/midi/midi_features.h - Issue 2352013002: MidiManagerWinrt as base::FeatureList feature

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/midi/midi_features.h

Issue 2352013002: MidiManagerWinrt as base::FeatureList feature (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_MIDI_MIDI_FEATURES_H_

	6 #define MEDIA_MIDI_MIDI_FEATURES_H_

	7

	8 #include "base/feature_list.h"

	9 #include "media/midi/midi_export.h"

	10

	11 namespace features {

	12

	13 #if defined(OS_WIN)

	14 MIDI_EXPORT extern const base::Feature kUseWinrtMidiApi;
	Takashi Toyoshima 2016/09/20 09:12:04 We do not use 'Use' or 'Enable' like prefix for th We do not use 'Use' or 'Enable' like prefix for the Feature API naming. Probably, kWinrtMidiManager would be fine. Shao-Chuan Lee 2016/09/20 09:57:27 Now using kMidiManagerWinrt to stick with the clas Show quoted text On 2016/09/20 09:12:04, toyoshim wrote: > We do not use 'Use' or 'Enable' like prefix for the Feature API naming. > Probably, kWinrtMidiManager would be fine. Now using kMidiManagerWinrt to stick with the class name.
	15 #endif

	16

	17 } // namespace features

	18

	19 #endif // MEDIA_MIDI_MIDI_FEATURES_H_
	Takashi Toyoshima 2016/09/20 09:12:04 Can we reuse midi_switches as media_switches does. Can we reuse midi_switches as media_switches does. Shao-Chuan Lee 2016/09/20 09:57:27 As discussed offline, now moved to midi_switches u Show quoted text On 2016/09/20 09:12:04, toyoshim wrote: > Can we reuse midi_switches as media_switches does. As discussed offline, now moved to midi_switches under namespace media::midi::features.
OLD	NEW