MD Settings: Replace language detail page with dropdown menu items

MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

As per mocks. Screenshot: https://crbug.com/630982#c11

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4
Cr-Commit-Position: refs/heads/master@{#420249}

[michaelpg, 2016-09-20 04:27:09]

Description was changed from

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

BUG=630982
==========

to

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

BUG=630982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-09-20 04:42:40]

Description was changed from

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

BUG=630982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

As per mocks. Screenshot: https://crbug.com/630982#c11

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-09-20 04:42:40]

michaelpg@chromium.org changed reviewers:
+ stevenjb@chromium.org

[michaelpg, 2016-09-20 04:49:43]

PTAL.

[stevenjb, 2016-09-20 16:17:59]

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:85:
hidden$="[[!isProspectiveUILanguage_(
We should at least be consistent with hidden= vs hidden$= within this file.

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:201:
hidden="[[!prefs.translate.enabled.value]]"
e.g. here.

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.js (right):

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:141: return
true;
Dupe

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:157: //
Otherwise, the prospective language can changed to/from this language.
can be changed

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:446:
this.$.menuTemplate.render();
This is interesting. Can you point me to the documentation for it (it's a
difficult term to search for...)

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:474: </if>
Ugh. It would be nice if we could make logOutAndRestart() behave the same as
restart() (or vice versa) on non chromeos.

[michaelpg, 2016-09-21 19:28:13]

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:85:
hidden$="[[!isProspectiveUILanguage_(
On 2016/09/20 16:17:59, stevenjb wrote:
> We should at least be consistent with hidden= vs hidden$= within this file.

Done.

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:201:
hidden="[[!prefs.translate.enabled.value]]"
On 2016/09/20 16:17:59, stevenjb wrote:
> e.g. here.

Acknowledged.

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.js (right):

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:141: return
true;
On 2016/09/20 16:17:59, stevenjb wrote:
> Dupe

Done.

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:157: //
Otherwise, the prospective language can changed to/from this language.
On 2016/09/20 16:17:59, stevenjb wrote:
> can be changed

Done.

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:446:
this.$.menuTemplate.render();
On 2016/09/20 16:17:59, stevenjb wrote:
> This is interesting. Can you point me to the documentation for it (it's a
> difficult term to search for...)

Changed this to use history's cr-lazy-render. But the documentation is here:
https://www.polymer-project.org/1.0/docs/api/dom-if#method-render

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:474: </if>
On 2016/09/20 16:17:59, stevenjb wrote:
> Ugh. It would be nice if we could make logOutAndRestart() behave the same as
> restart() (or vice versa) on non chromeos.

CrOS can also "restart" without the logOut, e.g. when changing chrome://flags.
Not sure when one is preferred, just following the existing code.

[stevenjb, 2016-09-21 19:45:56]

lgtm

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.js (right):

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:446:
this.$.menuTemplate.render();
On 2016/09/21 19:28:13, michaelpg wrote:
> On 2016/09/20 16:17:59, stevenjb wrote:
> > This is interesting. Can you point me to the documentation for it (it's a
> > difficult term to search for...)
> 
> Changed this to use history's cr-lazy-render. But the documentation is here:
> https://www.polymer-project.org/1.0/docs/api/dom-if#method-render

Ah, I missed that, thanks.

https://codereview.chromium.org/2351963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:474: </if>
On 2016/09/21 19:28:13, michaelpg wrote:
> On 2016/09/20 16:17:59, stevenjb wrote:
> > Ugh. It would be nice if we could make logOutAndRestart() behave the same as
> > restart() (or vice versa) on non chromeos.
> 
> CrOS can also "restart" without the logOut, e.g. when changing chrome://flags.
> Not sure when one is preferred, just following the existing code.

signOutAndRestart I think is correct on Chrome OS, but personally I would also
implement that on non-chromeos and make it just do a restart.

[michaelpg, 2016-09-21 22:20:56]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-09-21 22:20:57]

The CQ bit was unchecked by michaelpg@chromium.org

[michaelpg, 2016-09-22 02:04:16]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-09-22 02:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 03:22:08]

Description was changed from

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

As per mocks. Screenshot: https://crbug.com/630982#c11

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

As per mocks. Screenshot: https://crbug.com/630982#c11

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-22 03:22:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-22 03:26:15]

Description was changed from

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

As per mocks. Screenshot: https://crbug.com/630982#c11

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

As per mocks. Screenshot: https://crbug.com/630982#c11

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4
Cr-Commit-Position: refs/heads/master@{#420249}
==========

[commit-bot: I haz the power, 2016-09-22 03:26:16]

Patchset 6 (id:??) landed as
https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4
Cr-Commit-Position: refs/heads/master@{#420249}