Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2351963003: MD Settings: Replace language detail page with dropdown menu items (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/assert.html"> 1 <link rel="import" href="chrome://resources/html/assert.html">
2 <link rel="import" href="chrome://resources/html/cr.html"> 2 <link rel="import" href="chrome://resources/html/cr.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">
9 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
11 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_shared_menu/cr_shared _menu.html"> 12 <link rel="import" href="chrome://resources/cr_elements/cr_shared_menu/cr_shared _menu.html">
11 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 13 <link rel="import" href="chrome://resources/cr_elements/icons.html">
12 <link rel="import" href="/icons.html"> 14 <link rel="import" href="/icons.html">
15 <link rel="import" href="/languages_page/add_languages_dialog.html">
16 <link rel="import" href="/languages_page/languages.html">
17 <link rel="import" href="/lifetime_browser_proxy.html">
13 <link rel="import" href="/route.html"> 18 <link rel="import" href="/route.html">
14 <link rel="import" href="/settings_page/settings_animated_pages.html"> 19 <link rel="import" href="/settings_page/settings_animated_pages.html">
15 <link rel="import" href="/settings_page/settings_subpage.html"> 20 <link rel="import" href="/settings_page/settings_subpage.html">
16 <link rel="import" href="/settings_shared_css.html"> 21 <link rel="import" href="/settings_shared_css.html">
17 <link rel="import" href="add_languages_dialog.html">
18 <link rel="import" href="language_detail_page.html">
19 <link rel="import" href="languages.html">
20 22
21 <if expr="not is_macosx"> 23 <if expr="not is_macosx">
22 <link rel="import" href="edit_dictionary_page.html"> 24 <link rel="import" href="edit_dictionary_page.html">
23 </if> 25 </if>
24 26
25 <if expr="chromeos"> 27 <if expr="chromeos">
26 <link rel="import" href="manage_input_methods_page.html"> 28 <link rel="import" href="chrome://resources/html/chromeos/ui_account_tweaks.html ">
29 <link rel="import" href="/languages_page/manage_input_methods_page.html">
27 </if> 30 </if>
28 31
29 <dom-module id="settings-languages-page"> 32 <dom-module id="settings-languages-page">
30 <template> 33 <template>
31 <style include="settings-shared"> 34 <style include="settings-shared">
32 .list-button { 35 #languagesCollapse .list-item.selected {
33 @apply(--settings-actionable); 36 min-height: var(--settings-row-two-line-min-height);
37 }
38
39 .explain-selected {
40 color: var(--google-green-700);
41 font-weight: initial;
42 margin-top: 4px;
43 }
44
45 paper-checkbox.dropdown-item {
46 --checkbox-margin-start: 0;
47 /* Allow for the ripple height. */
48 min-height: var(--paper-checkbox-ink-size);
34 } 49 }
35 </style> 50 </style>
36 <settings-languages languages="{{languages}}" prefs="{{prefs}}" 51 <settings-languages languages="{{languages}}" prefs="{{prefs}}"
37 language-helper="{{languageHelper}}"> 52 language-helper="{{languageHelper}}">
38 </settings-languages> 53 </settings-languages>
39 <settings-animated-pages id="pages" section="languages"> 54 <settings-animated-pages id="pages" section="languages">
40 <neon-animatable route-path="default"> 55 <neon-animatable route-path="default">
41 <div class="settings-box first two-line"> 56 <div class="settings-box first two-line">
42 <div class="start"> 57 <div class="start">
43 <div>$i18n{languagesListTitle}</div> 58 <div>$i18n{languagesListTitle}</div>
(...skipping 10 matching lines...) Expand all
54 <span class="list-item" 69 <span class="list-item"
55 hidden="[[isHelpTextHidden_(languages.enabled.*)]]"> 70 hidden="[[isHelpTextHidden_(languages.enabled.*)]]">
56 <span>$i18n{orderLanguagesInstructions}</span> 71 <span>$i18n{orderLanguagesInstructions}</span>
57 <a href="$i18n{languagesLearnMoreURL}" target="_blank"> 72 <a href="$i18n{languagesLearnMoreURL}" target="_blank">
58 $i18n{learnMore} 73 $i18n{learnMore}
59 </a> 74 </a>
60 </span> 75 </span>
61 <template is="dom-repeat" items="[[languages.enabled]]"> 76 <template is="dom-repeat" items="[[languages.enabled]]">
62 <div class$="list-item [[getLanguageItemClass_( 77 <div class$="list-item [[getLanguageItemClass_(
63 item.language.code, prefs.intl.app_locale.value, 78 item.language.code, prefs.intl.app_locale.value,
64 item.language.supportsUI)]]" 79 item.language.supportsUI)]]">
65 on-tap="onLanguageTap_"> 80 <div class="start">
66 <if expr="not chromeos and not is_win"> 81 <div title="[[item.language.nativeDisplayName]]">
67 <div class="start" title="[[item.language.nativeDisplayName]]"> 82 [[item.language.displayName]]
68 [[item.language.displayName]] 83 </div>
84 <if expr="chromeos or is_win">
85 <div class="explain-selected"
86 hidden="[[!isProspectiveUILanguage_(
87 item.language.code, prefs.intl.app_locale.value)]]">
88 $i18n{isDisplayedInThisLanguage}
89 </div>
90 </if>
69 </div> 91 </div>
70 </if>
71 <if expr="chromeos or is_win"> 92 <if expr="chromeos or is_win">
72 <div title="[[item.language.nativeDisplayName]]"> 93 <template is="dom-if" if="[[isRestartRequired_(
73 [[item.language.displayName]] 94 item.language.code, prefs.intl.app_locale.value)]]">
74 </div> 95 <paper-button on-tap="onRestartTap_">
75 <div class="middle"> 96 $i18n{restart}
76 <iron-icon icon="settings:done" 97 </paper-button>
77 hidden$="[[!isProspectiveUILanguage_( 98 </template>
78 item.language.code, prefs.intl.app_locale.value)]]">
79 </iron-icon>
80 </div>
81 </if> 99 </if>
82 <paper-icon-button id="more-[[item.language.code]]" 100 <paper-icon-button id="more-[[item.language.code]]"
83 icon="cr:more-vert" on-tap="toggleMenu_"> 101 icon="cr:more-vert" on-tap="toggleMenu_">
84 </paper-icon-button> 102 </paper-icon-button>
85 </div> 103 </div>
86 </template> 104 </template>
87 <div class="list-item list-button" on-tap="onAddLanguagesTap_"> 105 <div class="list-item list-button" on-tap="onAddLanguagesTap_">
88 $i18n{addLanguages} 106 $i18n{addLanguages}
89 </div> 107 </div>
90 </div> 108 </div>
(...skipping 14 matching lines...) Expand all
105 opened="[[inputMethodsOpened_]]"> 123 opened="[[inputMethodsOpened_]]">
106 <div class="list-frame vertical-list"> 124 <div class="list-frame vertical-list">
107 <template is="dom-repeat" 125 <template is="dom-repeat"
108 items="[[languages.inputMethods.enabled]]"> 126 items="[[languages.inputMethods.enabled]]">
109 <div class$="list-item [[getInputMethodItemClass_( 127 <div class$="list-item [[getInputMethodItemClass_(
110 item.id, languages.inputMethods.currentId)]]" 128 item.id, languages.inputMethods.currentId)]]"
111 on-tap="onInputMethodTap_" actionable> 129 on-tap="onInputMethodTap_" actionable>
112 <div>[[item.displayName]]</div> 130 <div>[[item.displayName]]</div>
113 <div class="middle"> 131 <div class="middle">
114 <iron-icon icon="settings:done" 132 <iron-icon icon="settings:done"
115 hidden$="[[!isCurrentInputMethod_( 133 hidden="[[!isCurrentInputMethod_(
116 item.id, languages.inputMethods.currentId)]]"> 134 item.id, languages.inputMethods.currentId)]]">
117 </iron-icon> 135 </iron-icon>
118 </div> 136 </div>
119 <paper-icon-button icon="cr:settings" 137 <paper-icon-button icon="cr:settings"
120 on-tap="onInputMethodOptionsTap_" 138 on-tap="onInputMethodOptionsTap_"
121 hidden$="[[!item.hasOptionsPage]]"> 139 hidden="[[!item.hasOptionsPage]]">
122 </paper-icon-button> 140 </paper-icon-button>
123 </div> 141 </div>
124 </template> 142 </template>
125 <div class="list-item list-button" 143 <div class="list-item list-button"
126 on-tap="onManageInputMethodsTap_"> 144 on-tap="onManageInputMethodsTap_">
127 $i18n{manageInputMethods} 145 $i18n{manageInputMethods}
128 </div> 146 </div>
129 </div> 147 </div>
130 </iron-collapse> 148 </iron-collapse>
131 </if> 149 </if>
(...skipping 26 matching lines...) Expand all
158 "supportsSpellCheckLabel-[[item.language.code]]"> 176 "supportsSpellCheckLabel-[[item.language.code]]">
159 </paper-toggle-button> 177 </paper-toggle-button>
160 </label> 178 </label>
161 </template> 179 </template>
162 <div class="list-item list-button" on-tap="onEditDictionaryTap_"> 180 <div class="list-item list-button" on-tap="onEditDictionaryTap_">
163 $i18n{manageSpellCheck} 181 $i18n{manageSpellCheck}
164 </div> 182 </div>
165 </div> 183 </div>
166 </iron-collapse> 184 </iron-collapse>
167 </if> 185 </if>
168 <template is="dom-if" id="menuTemplate"> 186 <template is="cr-lazy-render" id="menu">
169 <cr-shared-menu> 187 <cr-shared-menu>
188 <if expr="chromeos or is_win">
189 <paper-checkbox id="uiLanguageItem" class="dropdown-item"
190 checked="[[isProspectiveUILanguage_(
191 detailLanguage_.language.code,
192 prefs.intl.app_locale.value)]]"
193 on-change="onUILanguageChange_"
194 disabled="[[disableUILanguageCheckbox_(
195 detailLanguage_, prefs.intl.app_locale.value)]]">
196 $i18n{displayInThisLanguage}
197 </paper-checkbox>
198 </if>
199 <paper-checkbox class="dropdown-item"
200 checked="[[detailLanguage_.translateEnabled]]"
201 on-change="onTranslateCheckboxChange_"
202 hidden="[[!prefs.translate.enabled.value]]"
203 disabled="[[disableTranslateCheckbox_(
204 detailLanguage_.language, languages.translateTarget)]]">
205 $i18n{offerToTranslateInThisLanguage}
206 </paper-checkbox>
170 <button class="dropdown-item" role="menuitem" 207 <button class="dropdown-item" role="menuitem"
171 on-tap="onMoveUpTap_" 208 on-tap="onMoveUpTap_"
172 hidden="[[isFirstLanguage_( 209 hidden="[[isFirstLanguage_(
173 detailLanguage_, languages.enabled.*)]]"> 210 detailLanguage_, languages.enabled.*)]]">
174 $i18n{moveUp} 211 $i18n{moveUp}
175 </button> 212 </button>
176 <button class="dropdown-item" role="menuitem" 213 <button class="dropdown-item" role="menuitem"
177 on-tap="onMoveDownTap_" 214 on-tap="onMoveDownTap_"
178 hidden="[[isLastLanguage_( 215 hidden="[[isLastLanguage_(
179 detailLanguage_, languages.enabled.*)]]"> 216 detailLanguage_, languages.enabled.*)]]">
180 $i18n{moveDown} 217 $i18n{moveDown}
181 </button> 218 </button>
182 <button class="dropdown-item" role="menuitem" 219 <button class="dropdown-item" role="menuitem"
183 on-tap="onShowLanguageDetailTap_">
184 $i18n{languageDetail}
185 </button>
186 <button class="dropdown-item" role="menuitem"
187 on-tap="onRemoveLanguageTap_" 220 on-tap="onRemoveLanguageTap_"
188 disabled="[[!detailLanguage_.removable]]"> 221 hidden="[[!detailLanguage_.removable]]">
189 $i18n{removeLanguage} 222 $i18n{removeLanguage}
190 </button> 223 </button>
191 </cr-shared-menu> 224 </cr-shared-menu>
192 </template> 225 </template>
193 </neon-animatable> 226 </neon-animatable>
194 <template is="dom-if" route-path="/languages/edit" no-search>
195 <settings-subpage page-title="[[detailLanguage_.language.displayName]]">
196 <settings-language-detail-page id="languageDetailPage"
197 languages="{{languages}}" prefs="{{prefs}}"
198 detail="[[detailLanguage_]]" language-helper="[[languageHelper]]">
199 </settings-language-detail-page>
200 </settings-subpage>
201 </template>
202 <if expr="chromeos"> 227 <if expr="chromeos">
203 <template is="dom-if" route-path="/inputMethods"> 228 <template is="dom-if" route-path="/inputMethods">
204 <settings-subpage 229 <settings-subpage
205 associated-control="[[$$('#manage-input-methods-subpage-trigger')]]" 230 associated-control="[[$$('#manage-input-methods-subpage-trigger')]]"
206 page-title="$i18n{manageInputMethodsPageTitle}"> 231 page-title="$i18n{manageInputMethodsPageTitle}">
207 <settings-manage-input-methods-page languages="{{languages}}" 232 <settings-manage-input-methods-page languages="{{languages}}"
208 language-helper="[[languageHelper]]"> 233 language-helper="[[languageHelper]]">
209 </settings-manage-input-methods-page> 234 </settings-manage-input-methods-page>
210 </settings-subpage> 235 </settings-subpage>
211 </template> 236 </template>
212 </if> 237 </if>
213 <if expr="not is_macosx"> 238 <if expr="not is_macosx">
214 <template is="dom-if" route-path="/editDictionary"> 239 <template is="dom-if" route-path="/editDictionary">
215 <settings-subpage 240 <settings-subpage
216 associated-control="[[$$('#spellcheck-subpage-trigger')]]" 241 associated-control="[[$$('#spellcheck-subpage-trigger')]]"
217 page-title="$i18n{editDictionaryPageTitle}"> 242 page-title="$i18n{editDictionaryPageTitle}">
218 <settings-edit-dictionary-page></settings-edit-dictionary-page> 243 <settings-edit-dictionary-page></settings-edit-dictionary-page>
219 </settings-subpage> 244 </settings-subpage>
220 </template> 245 </template>
221 </if> 246 </if>
222 </settings-animated-pages> 247 </settings-animated-pages>
223 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 248 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
224 <settings-add-languages-dialog languages="{{languages}}" 249 <settings-add-languages-dialog languages="{{languages}}"
225 language-helper="[[languageHelper]]"> 250 language-helper="[[languageHelper]]">
226 </settings-add-languages-dialog> 251 </settings-add-languages-dialog>
227 </template> 252 </template>
228 </template> 253 </template>
229 <script src="languages_page.js"></script> 254 <script src="languages_page.js"></script>
230 </dom-module> 255 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698