Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2567)

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2351963003: MD Settings: Replace language detail page with dropdown menu items (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/languages_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js
index b563d3d57727342cf5ffe22838ab63dc69cf098c..d03d93da522b827b798ace9778c21e6250f6074f 100644
--- a/chrome/test/data/webui/settings/languages_page_browsertest.js
+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js
@@ -235,7 +235,7 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
var languageMenu = assert(languagesPage.$$('cr-shared-menu'));
assertTrue(languageMenu.menuOpen);
var removeMenuItem = assert(languageMenu.querySelector(
- '.dropdown-item:last-of-type'));
+ '.dropdown-item:last-child'));
assertFalse(removeMenuItem.disabled);
MockInteractions.tap(removeMenuItem);
assertFalse(languageMenu.menuOpen);
@@ -247,20 +247,6 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
});
});
- test('language detail', function() {
- var languageOptionsDropdownTrigger = languagesCollapse.querySelector(
- 'paper-icon-button');
- MockInteractions.tap(languageOptionsDropdownTrigger);
- var languageDetailMenuItem = languagesPage.root.querySelectorAll(
- 'cr-shared-menu .dropdown-item')[2];
- MockInteractions.tap(languageDetailMenuItem);
-
- var languageDetailPage =
- languagesPage.$$('settings-language-detail-page');
- assertTrue(!!languageDetailPage);
- assertEquals('en-US', languageDetailPage.detail.language.code);
- });
-
test('manage input methods', function() {
var inputMethodsCollapse = languagesPage.$.inputMethodsCollapse;
var inputMethodSettingsExist = !!inputMethodsCollapse;
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698