Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2351903003: Revert of Disable flaky MigrationSingleClientTest tests. (Closed)

Created:
4 years, 3 months ago by ymalik
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky MigrationSingleClientTest tests. (patchset #1 id:1 of https://codereview.chromium.org/2353953002/ ) Reason for revert: No need to disable these tests as the flakyness was fixed by https://codereview.chromium.org/2338213009 Original issue's description: > Disable flaky MigrationSingleClientTest tests. > > These are reported as flaky. Though locally they fail every time? > > Disabling: > - MigrationSingleClientTest.AllTypesAtOnce > - MigrationSingleClientTest.AllTypesAtOnceTriggerNotification > - MigrationSingleClientTest.AllTypesWithNigoriAtOnce > - MigrationSingleClientTest.BookmarksPrefsBoth > - MigrationSingleClientTest.BookmarksPrefsIndividually > - MigrationSingleClientTest.NigoriOnly > - MigrationSingleClientTest.PrefsNigoriBoth > - MigrationSingleClientTest.PrefsOnlyModifyBookmark > - MigrationSingleClientTest.PrefsOnlyModifyPref > - MigrationSingleClientTest.PrefsOnlyTriggerNotification > > With this, *ALL* MigrationSingleClientTests that were not already > disabled are disabled. This bug needs to be investigated and the tests > re-enabled. > > BUG=648480 > NOTRY=True > TBR=lgcheng,stevenjb,pavely > > Committed: https://crrev.com/76ad59ea95d48f29f5b8658d467d6323789f1b51 > Cr-Commit-Position: refs/heads/master@{#419757} TBR=lgcheng@google.com,pavely@chromium.org,stevenjb@chromium.org,hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648480 Committed: https://crrev.com/f58e5fea14e496cc7bf2b4af814e1c4726b07f87 Cr-Commit-Position: refs/heads/master@{#419766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M chrome/browser/sync/test/integration/migration_test.cc View 4 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ymalik
Created Revert of Disable flaky MigrationSingleClientTest tests.
4 years, 3 months ago (2016-09-20 15:14:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351903003/1
4 years, 3 months ago (2016-09-20 15:15:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 15:16:16 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 15:19:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f58e5fea14e496cc7bf2b4af814e1c4726b07f87
Cr-Commit-Position: refs/heads/master@{#419766}

Powered by Google App Engine
This is Rietveld 408576698