Always use valid enum values in gfx::ColorSpace

Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Committed: https://crrev.com/1ce3ef909814ab9de65c09646c4f6c2b2e340d0c
Cr-Original-Commit-Position: refs/heads/master@{#419552}
Cr-Commit-Position: refs/heads/master@{#419615}

[hubbe, 2016-09-16 20:53:33]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:54:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2016-09-16 20:54:05]

hubbe@chromium.org changed reviewers:
+ ccameron@chromium.org, sandersd@chromium.org

[commit-bot: I haz the power, 2016-09-16 21:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 21:18:33]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[hubbe, 2016-09-16 21:32:22]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 21:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sandersd (OOO until July 31), 2016-09-16 21:58:59]

lgtm.

(I did not check your numbers or math against any specs.)

[commit-bot: I haz the power, 2016-09-16 22:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:24:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-09-16 23:09:48]

Also looks like there are some test failures

https://codereview.chromium.org/2338213009/diff/20001/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2338213009/diff/20001/ui/gfx/color_space.h#ne...
ui/gfx/color_space.h:52: LAST = UNKNOWN
Should this be CUSTOM?

[hubbe, 2016-09-16 23:25:17]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:25:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2016-09-16 23:25:35]

Tests fixed.

https://codereview.chromium.org/2338213009/diff/20001/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2338213009/diff/20001/ui/gfx/color_space.h#ne...
ui/gfx/color_space.h:52: LAST = UNKNOWN
On 2016/09/16 23:09:48, ccameron wrote:
> Should this be CUSTOM?

Ooops, yes, I rearranged it so that UNKNOWN is always 1000, but then missed
this.

[commit-bot: I haz the power, 2016-09-17 02:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 02:33:44]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-09-19 18:03:37]

lgtm

[hubbe, 2016-09-19 19:21:47]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2016-09-19 19:21:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2338213009/#ps40001
(title: "tests pass")

[commit-bot: I haz the power, 2016-09-19 19:22:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:16:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-19 21:18:17]

Description was changed from

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.
==========

to

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Cr-Commit-Position: refs/heads/master@{#419552}
==========

[commit-bot: I haz the power, 2016-09-19 21:18:17]

Patchset 3 (id:??) landed as
https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Cr-Commit-Position: refs/heads/master@{#419552}

[Dmitry Titov, 2016-09-19 22:48:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2352903002/ by dimich@chromium.org.

The reason for reverting is: broke build: 

https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Rel...

DCHECK failure: 

[29864:20227:0919/143752:FATAL:gfx_param_traits_macros.h(19)] Check failed:
(static_cast<int>(value) >= static_cast<int>(0) && static_cast<int>(value) <=
static_cast<int>(gfx::ColorSpace::PrimaryID::LAST)). 
0   Chromium Framework                  0x0000000107a6caf3
_ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x0000000107a8eb17
_ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x00000001090ac690
_ZN3IPC11ParamTraitsIN3gfx10ColorSpaceEE5WriteEPN4base6PickleERKS2_ + 96
3   Chromium Framework                  0x000000010909096e
_ZN3IPC11ParamTraitsIN2cc20TransferableResourceEE5WriteEPN4base6PickleERKS2_ +
270.

[hubbe, 2016-09-19 22:49:22]

Description was changed from

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Cr-Commit-Position: refs/heads/master@{#419552}
==========

to

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Cr-Commit-Position: refs/heads/master@{#419552}
==========

[hubbe, 2016-09-19 22:49:28]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:49:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 22:52:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 22:52:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hubbe, 2016-09-19 23:16:34]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 23:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2016-09-20 00:25:59]

The CQ bit was unchecked by hubbe@chromium.org

[hubbe, 2016-09-20 00:26:04]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2016-09-20 00:26:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org, ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2338213009/#ps80001
(title: "merge")

[commit-bot: I haz the power, 2016-09-20 00:26:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:04:39]

Description was changed from

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Cr-Commit-Position: refs/heads/master@{#419552}
==========

to

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Cr-Commit-Position: refs/heads/master@{#419552}
==========

[commit-bot: I haz the power, 2016-09-20 01:04:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-20 01:06:46]

Description was changed from

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Cr-Commit-Position: refs/heads/master@{#419552}
==========

to

==========
Always use valid enum values in gfx::ColorSpace

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Committed: https://crrev.com/1ce3ef909814ab9de65c09646c4f6c2b2e340d0c
Cr-Original-Commit-Position: refs/heads/master@{#419552}
Cr-Commit-Position: refs/heads/master@{#419615}
==========

[commit-bot: I haz the power, 2016-09-20 01:06:47]

Patchset 5 (id:??) landed as
https://crrev.com/1ce3ef909814ab9de65c09646c4f6c2b2e340d0c
Cr-Commit-Position: refs/heads/master@{#419615}