Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/sync/test/integration/migration_test.cc

Issue 2351903003: Revert of Disable flaky MigrationSingleClientTest tests. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/migration_test.cc
diff --git a/chrome/browser/sync/test/integration/migration_test.cc b/chrome/browser/sync/test/integration/migration_test.cc
index 0431a0e9a9d48b66f2eac68eb909db746515f475..13ddb0192306c1ef122e83d3e92306d5fa8a8e73 100644
--- a/chrome/browser/sync/test/integration/migration_test.cc
+++ b/chrome/browser/sync/test/integration/migration_test.cc
@@ -240,40 +240,37 @@
// The simplest possible migration tests -- a single data type.
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
- DISABLED_PrefsOnlyModifyPref) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsOnlyModifyPref) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES), MODIFY_PREF);
}
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
- DISABLED_PrefsOnlyModifyBookmark) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsOnlyModifyBookmark) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES),
MODIFY_BOOKMARK);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
- DISABLED_PrefsOnlyTriggerNotification) {
+ PrefsOnlyTriggerNotification) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES),
TRIGGER_NOTIFICATION);
}
// Nigori is handled specially, so we test that separately.
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, DISABLED_NigoriOnly) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, NigoriOnly) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES),
TRIGGER_NOTIFICATION);
}
// A little more complicated -- two data types.
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
- DISABLED_BookmarksPrefsIndividually) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, BookmarksPrefsIndividually) {
RunSingleClientMigrationTest(
MakeList(syncer::BOOKMARKS, syncer::PREFERENCES),
MODIFY_PREF);
}
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, DISABLED_BookmarksPrefsBoth) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, BookmarksPrefsBoth) {
RunSingleClientMigrationTest(
MakeList(MakeSet(syncer::BOOKMARKS, syncer::PREFERENCES)),
MODIFY_BOOKMARK);
@@ -289,7 +286,7 @@
TRIGGER_NOTIFICATION);
}
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, DISABLED_PrefsNigoriBoth) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriBoth) {
RunSingleClientMigrationTest(
MakeList(MakeSet(syncer::PREFERENCES, syncer::NIGORI)),
MODIFY_PREF);
@@ -311,14 +308,14 @@
TRIGGER_NOTIFICATION);
}
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, DISABLED_AllTypesAtOnce) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesAtOnce) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()),
MODIFY_PREF);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
- DISABLED_AllTypesAtOnceTriggerNotification) {
+ AllTypesAtOnceTriggerNotification) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()),
TRIGGER_NOTIFICATION);
@@ -335,8 +332,7 @@
RunSingleClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
- DISABLED_AllTypesWithNigoriAtOnce) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesWithNigoriAtOnce) {
ASSERT_TRUE(SetupClients());
syncer::ModelTypeSet all_types = GetPreferredDataTypes();
all_types.Put(syncer::NIGORI);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698