Prune CreateVisiblePositionDeprecated from DOMSelection

Prune CreateVisiblePositionDeprecated from DOMSelection

BUG=647219
Committed: https://crrev.com/7cd2a1fec6f76746a8230a9debe04be1160b7569
Cr-Commit-Position: refs/heads/master@{#419718}

[Xiaocheng, 2016-09-20 02:16:32]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 02:16:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 03:42:50]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-20 03:42:51]

PTAL.

[commit-bot: I haz the power, 2016-09-20 05:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 05:01:07]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-09-20 08:33:17]

lgtm w/ nits

https://codereview.chromium.org/2351533005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2351533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:246:
m_frame->selection().moveTo(selection.end(), SelDefaultAffinity);
Please get rid of FrameSelection::moveTo(const VisibilePosition&, ...) in
another patch. ;-)
Is it better to mention in description?

https://codereview.chromium.org/2351533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:294:
m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
nit: It seems strange that making layout tree clean here, before calling
|createPosiion()|.
And since |VisibleSelection| ctor makes layout tree clean. we don't need to
update layout tree now.

Let postpone calling update layout here until we hoist update layout tree from
|VisibleSelection| ctor.

[Xiaocheng, 2016-09-20 08:56:22]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 08:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 08:56:38]

Thanks. Updated.

https://codereview.chromium.org/2351533005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2351533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:246:
m_frame->selection().moveTo(selection.end(), SelDefaultAffinity);
On 2016/09/20 at 08:33:17, Yosi_UTC9 wrote:
> Please get rid of FrameSelection::moveTo(const VisibilePosition&, ...) in
another patch. ;-)
> Is it better to mention in description?

A TODO is added to FrameSelection::moveTo(VP).

https://codereview.chromium.org/2351533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:294:
m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/09/20 at 08:33:17, Yosi_UTC9 wrote:
> nit: It seems strange that making layout tree clean here, before calling
|createPosiion()|.
> And since |VisibleSelection| ctor makes layout tree clean. we don't need to
update layout tree now.
> 
> Let postpone calling update layout here until we hoist update layout tree from
|VisibleSelection| ctor.

Done.

https://codereview.chromium.org/2351533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:294:
m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/09/20 at 08:33:17, Yosi_UTC9 wrote:
> nit: It seems strange that making layout tree clean here, before calling
|createPosiion()|.
> And since |VisibleSelection| ctor makes layout tree clean. we don't need to
update layout tree now.
> 
> Let postpone calling update layout here until we hoist update layout tree from
|VisibleSelection| ctor.

Reasonable. Done.

[commit-bot: I haz the power, 2016-09-20 10:12:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 10:12:32]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-20 10:24:05]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-09-20 10:24:05]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2351533005/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-20 10:24:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 10:29:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 10:33:03]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from DOMSelection

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from DOMSelection

BUG=647219

Committed: https://crrev.com/7cd2a1fec6f76746a8230a9debe04be1160b7569
Cr-Commit-Position: refs/heads/master@{#419718}
==========

[commit-bot: I haz the power, 2016-09-20 10:33:04]

Patchset 2 (id:??) landed as
https://crrev.com/7cd2a1fec6f76746a8230a9debe04be1160b7569
Cr-Commit-Position: refs/heads/master@{#419718}