third_party/WebKit/Source/core/editing/FrameSelection.h - Issue 2351533005: Prune CreateVisiblePositionDeprecated from DOMSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2351533005: Prune CreateVisiblePositionDeprecated from DOMSelection (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.h

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h

index 3761dda5677f206e7915eee5a6eb17cc815d240e..05ebac48e30ff599f387eb3586bba1d3dd5e0e87 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.h

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h

@@ -107,6 +107,7 @@ public:

bool isContentEditable() const { return selection().isContentEditable(); }

bool isContentRichlyEditable() const { return selection().isContentRichlyEditable(); }

+ // TODO(xiaochengh): Remove the |moveTo(VisiblePosition)| overload.

void moveTo(const VisiblePosition&, EUserTriggered = NotUserTriggered, CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded);

void moveTo(const Position&, TextAffinity);

« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »