Prune CreateVisiblePositionDeprecated from DOMSelection

third_party/WebKit/Source/core/editing/DOMSelection.cpp

 /*
  * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 225 matching lines @@
     if (!isAvailable())
         return;
 
     const VisibleSelection& selection = m_frame->selection().selection();
 
     if (selection.isNone()) {
         exceptionState.throwDOMException(InvalidStateError, "there is no selection.");
         return;
     }
 
-    m_frame->selection().moveTo(createVisiblePositionDeprecated(selection.end()));
+    m_frame->selection().moveTo(selection.end(), SelDefaultAffinity);

[yosin_UTC9, 2016/09/20 08:33:17]

Please get rid of FrameSelection::moveTo(const VisibilePosition&, ...) in
another patch. ;-)
Is it better to mention in description?

[Xiaocheng, 2016/09/20 08:56:37]

A TODO is added to FrameSelection::moveTo(VP).

 }
 
 void DOMSelection::collapseToStart(ExceptionState& exceptionState)
 {
     if (!isAvailable())
         return;
 
     const VisibleSelection& selection = m_frame->selection().selection();
 
     if (selection.isNone()) {
         exceptionState.throwDOMException(InvalidStateError, "there is no selection.");
         return;
     }
 
-    m_frame->selection().moveTo(createVisiblePositionDeprecated(selection.start()));
+    m_frame->selection().moveTo(selection.start(), SelDefaultAffinity);
 }
 
 void DOMSelection::empty()
 {
     if (!isAvailable())
         return;
     m_frame->selection().clear();
 }
 
 void DOMSelection::setBaseAndExtent(Node* baseNode, int baseOffset, Node* extentNode, int extentOffset, ExceptionState& exceptionState)
@@ skipping 10 matching lines @@
         exceptionState.throwDOMException(IndexSizeError, String::number(extentOffset) + " is not a valid extent offset.");
         return;
     }
 
     if (!baseNode || !extentNode)
         UseCounter::count(m_frame, UseCounter::SelectionSetBaseAndExtentNull);
 
     if (!isValidForPosition(baseNode) || !isValidForPosition(extentNode))
         return;
 
-    VisiblePosition visibleBase = createVisiblePositionDeprecated(createPosition(baseNode, baseOffset));
-    VisiblePosition visibleExtent = createVisiblePositionDeprecated(createPosition(extentNode, extentOffset));
+    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+    // needs to be audited.  See http://crbug.com/590369 for more details.
+    m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();

[yosin_UTC9, 2016/09/20 08:33:17]

nit: It seems strange that making layout tree clean here, before calling
|createPosiion()|.
And since |VisibleSelection| ctor makes layout tree clean. we don't need to
update layout tree now.

Let postpone calling update layout here until we hoist update layout tree from
|VisibleSelection| ctor.

[Xiaocheng, 2016/09/20 08:56:38]

Reasonable. Done.

[Xiaocheng, 2016/09/20 08:56:38]

Done.

+
+    Position base = createPosition(baseNode, baseOffset);
+    Position extent = createPosition(extentNode, extentOffset);
     const bool selectionHasDirection = true;
-    m_frame->selection().setSelection(VisibleSelection(visibleBase, visibleExtent, selectionHasDirection));
+    m_frame->selection().setSelection(VisibleSelection(base, extent, SelDefaultAffinity, selectionHasDirection));
 }
 
 void DOMSelection::modify(const String& alterString, const String& directionString, const String& granularityString)
 {
     if (!isAvailable())
         return;
 
     FrameSelection::EAlteration alter;
     if (equalIgnoringCase(alterString, "extend"))
         alter = FrameSelection::AlterationExtend;
@@ skipping 282 matching lines @@
         m_treeScope->document().addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
 DEFINE_TRACE(DOMSelection)
 {
     visitor->trace(m_treeScope);
     DOMWindowProperty::trace(visitor);
 }
 
 } // namespace blink