Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 23514071: Do not explicitly use --force-compositing-mode in memory/throughput tests; use the default config f… (Closed)

Created:
7 years, 3 months ago by gab
Modified:
7 years, 3 months ago
Reviewers:
Zhenyao Mo, nduca
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, chrome-speed-team+watch_google.com, darin-cc_chromium.org, piman+watch_chromium.org, Vangelis Kokkevis
Visibility:
Public.

Description

Do not explicitly use --force-compositing-mode in memory/throughput tests; use the default config for that platform instead. Explicitly using --force-compositing-mode enabled FCM on bots where it is blacklisted in http://crrev.com/221643 as we decided to make the flags take precedence over the blacklist decision. This depends on https://codereview.chromium.org/23447045/ as it would otherwise disable FCM on perf bots for Mac 10.8. BUG=286540 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224350

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/test/perf/rendering/throughput_tests.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/gpu/gpu_memory_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gab
Mo/Nat, PTAL. This must go after https://codereview.chromium.org/23447045/ Thanks! Gab
7 years, 3 months ago (2013-09-18 18:15:00 UTC) #1
nduca
lgtm
7 years, 3 months ago (2013-09-19 14:57:23 UTC) #2
gab
ping: zmo. https://codereview.chromium.org/23447045 landed and this is thus ready to go (and hopefully will fix ...
7 years, 3 months ago (2013-09-19 18:14:54 UTC) #3
Zhenyao Mo
On 2013/09/19 18:14:54, gab wrote: > ping: zmo. > > https://codereview.chromium.org/23447045 landed and this is ...
7 years, 3 months ago (2013-09-19 23:23:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/23514071/5001
7 years, 3 months ago (2013-09-20 05:43:32 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 09:39:33 UTC) #6
Message was sent while issue was closed.
Change committed as 224350

Powered by Google App Engine
This is Rietveld 408576698