Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 23447045: Always enable FCM on Mac 10.8. (Closed)

Created:
7 years, 3 months ago by gab
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, Vangelis Kokkevis, ccameron (do not use)
Visibility:
Public.

Description

Always enable FCM on Mac 10.8. This is the Mac equivalent of Windows' http://crrev.com/221643. This needs to land before https://codereview.chromium.org/23514071/. BUG=286540 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224037

Patch Set 1 #

Total comments: 2

Patch Set 2 : review: zmo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 2 chunks +12 lines, -16 lines 0 comments Download
M content/browser/gpu/compositor_util_browsertest.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
gab
Mo, PTAL, thanks!
7 years, 3 months ago (2013-09-18 18:14:00 UTC) #1
Vangelis Kokkevis
Adding ccameron as well since he's been fighting with the mac bots.
7 years, 3 months ago (2013-09-18 20:18:16 UTC) #2
Zhenyao Mo
LGTM https://codereview.chromium.org/23447045/diff/1/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/23447045/diff/1/content/browser/gpu/compositor_util.cc#newcode96 content/browser/gpu/compositor_util.cc:96: // the field trial check to ensure this ...
7 years, 3 months ago (2013-09-18 20:43:59 UTC) #3
ccameron
lgtm -- simpler to look at, too
7 years, 3 months ago (2013-09-18 20:57:16 UTC) #4
gab
https://codereview.chromium.org/23447045/diff/1/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/23447045/diff/1/content/browser/gpu/compositor_util.cc#newcode96 content/browser/gpu/compositor_util.cc:96: // the field trial check to ensure this is ...
7 years, 3 months ago (2013-09-18 21:00:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/23447045/2001
7 years, 3 months ago (2013-09-18 21:03:23 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 05:04:10 UTC) #7
Message was sent while issue was closed.
Change committed as 224037

Powered by Google App Engine
This is Rietveld 408576698