chrome/browser/apps/web_view_interactive_browsertest.cc - Issue 23514016: <webview>: Cleanup WebRequest event listeners when embedder destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_interactive_browsertest.cc

Issue 23514016: <webview>: Cleanup WebRequest event listeners when embedder destroyed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/web_view_browsertest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api.h » ('j') | chrome/browser/extensions/api/web_request/web_request_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/web_view_interactive_browsertest.cc

diff --git a/chrome/browser/apps/web_view_interactive_browsertest.cc b/chrome/browser/apps/web_view_interactive_browsertest.cc

index bf1e4ec43bbf5719e8522df6ccecb7fe024665e5..6ab0e41e8f726f68f2d66a97c8c3ff57690b0d2f 100644

--- a/chrome/browser/apps/web_view_interactive_browsertest.cc

+++ b/chrome/browser/apps/web_view_interactive_browsertest.cc

@@ -576,6 +576,14 @@ IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,

"web_view/newwindow");

}

+IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,

lazyboy 2013/08/30 17:10:11 A bug number here for reference to added DISABLED_

+ DISABLED_NewWindow_WebRequestCloseWindow) {

+ TestHelper("testNewWindowWebRequestCloseWindow",

+ "DoneNewWindowTest.PASSED",

+ "DoneNewWindowTest.FAILED",

+ "web_view/newwindow");

IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, ExecuteCode) {

ASSERT_TRUE(StartEmbeddedTestServer()); // For serving guest pages.

ASSERT_TRUE(RunPlatformAppTestWithArg(