<webview>: Cleanup WebRequest event listeners when embedder destroyed

chrome/browser/extensions/api/web_request/web_request_api.cc

Index: chrome/browser/extensions/api/web_request/web_request_api.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc
index efb09247dbd17e25ecf661bba95e905506ab01d5..c073d90ac70faa3592c13908cde780d532974ec4 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc
@@ -397,7 +397,6 @@ struct ExtensionWebRequestEventRouter::EventListener {
   RequestFilter filter;
   int extra_info_spec;
   int embedder_process_id;
-  int embedder_routing_id;
   int webview_instance_id;
   base::WeakPtr<IPC::Sender> ipc_sender;
   mutable std::set<uint64> blocked_requests;
@@ -1173,7 +1172,6 @@ bool ExtensionWebRequestEventRouter::AddEventListener(
     const RequestFilter& filter,
     int extra_info_spec,
     int embedder_process_id,
-    int embedder_routing_id,
     int webview_instance_id,
     base::WeakPtr<IPC::Sender> ipc_sender) {
 
@@ -1188,7 +1186,6 @@ bool ExtensionWebRequestEventRouter::AddEventListener(
   listener.extra_info_spec = extra_info_spec;
   listener.ipc_sender = ipc_sender;
   listener.embedder_process_id = embedder_process_id;
-  listener.embedder_routing_id = embedder_routing_id;
   listener.webview_instance_id = webview_instance_id;
   if (listener.webview_instance_id)
     RecordAction(content::UserMetricsAction("WebView.WebRequest.AddListener"));
@@ -1241,7 +1238,6 @@ void ExtensionWebRequestEventRouter::RemoveWebViewEventListeners(
     void* profile,
     const std::string& extension_id,
     int embedder_process_id,
-    int embedder_routing_id,
     int webview_instance_id) {
   // Iterate over all listeners of all WebRequest events to delete
   // any listeners that belong to the provided <webview>.
@@ -1256,7 +1252,6 @@ void ExtensionWebRequestEventRouter::RemoveWebViewEventListeners(
       // TODO(fsamuel): Investigate making <webview> instance IDs unique within

[lazyboy, 2013/08/30 17:10:11]

This is what you are fixing too, so remove this TODO.

[Fady Samuel, 2013/08/30 17:20:15]

Done.

       // a process.
       if (listener.embedder_process_id == embedder_process_id &&
-          listener.embedder_routing_id == embedder_routing_id &&
           listener.webview_instance_id == webview_instance_id)
         listeners_to_delete.push_back(listener);
     }
@@ -1378,7 +1373,6 @@ void ExtensionWebRequestEventRouter::GetMatchingListenersImpl(
 
     if (is_guest &&
         (it->embedder_process_id != webview_info.embedder_process_id ||
-         it->embedder_routing_id != webview_info.embedder_routing_id ||
          it->webview_instance_id != webview_info.instance_id))
       continue;
 
@@ -2089,7 +2083,6 @@ bool WebRequestAddEventListener::RunImpl() {
 
   int embedder_process_id =
       ipc_sender.get() ? ipc_sender->render_process_id() : -1;
-  int embedder_routing_id = routing_id();
 
   const Extension* extension =
       extension_info_map()->extensions().GetByID(extension_id());
@@ -2124,8 +2117,7 @@ bool WebRequestAddEventListener::RunImpl() {
       ExtensionWebRequestEventRouter::GetInstance()->AddEventListener(
           profile_id(), extension_id(), extension_name,
           event_name, sub_event_name, filter, extra_info_spec,
-          embedder_process_id, embedder_routing_id, webview_instance_id,
-          ipc_sender_weak());
+          embedder_process_id, webview_instance_id, ipc_sender_weak());
   EXTENSION_FUNCTION_VALIDATE(success);
 
   helpers::ClearCacheOnNavigation();