chrome/browser/apps/web_view_browsertest.cc - Issue 23514016: <webview>: Cleanup WebRequest event listeners when embedder destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 23514016: <webview>: Cleanup WebRequest event listeners when embedder destroyed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/web_view_browsertest.cc

diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc

index 0166c5b714018d40bc7dc8ea6fafc710ef328729..f3edd5a7112b132349df916681a97a0368ea79b6 100644

--- a/chrome/browser/apps/web_view_browsertest.cc

+++ b/chrome/browser/apps/web_view_browsertest.cc

@@ -796,6 +796,14 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestWebRequestAPIGoogleProperty) {

"web_view/shim");

}

+IN_PROC_BROWSER_TEST_F(WebViewTest,

+ Shim_TestWebRequestListenerSurvivesReparenting) {

+ TestHelper("testWebRequestListenerSurvivesReparenting",

+ "DoneShimTest.PASSED",

+ "DoneShimTest.FAILED",

+ "web_view/shim");

IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestLoadStartLoadRedirect) {

TestHelper("testLoadStartLoadRedirect",

"DoneShimTest.PASSED",

« no previous file with comments | « no previous file | chrome/browser/apps/web_view_interactive_browsertest.cc » ('j') | chrome/browser/apps/web_view_interactive_browsertest.cc » ('J')