Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: extensions/extensions.gyp

Issue 23513035: Create separate extensions_common and extensions_browser GYP targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: c4267 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/extensions.gyp
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..ebcdbfa8c9827580c94373560611649e9bebe5e2
--- /dev/null
+++ b/extensions/extensions.gyp
@@ -0,0 +1,113 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
Nico 2013/10/23 18:26:59 This is missing chromium_source: 1. Adding this in
+ 'targets': [
+ {
+ 'target_name': 'extensions_common',
+ 'type': 'static_library',
Nico 2013/10/23 18:26:59 Is this intentionally not a <(component)?
Yoyo Zhou 2013/10/24 01:23:43 I think something didn't compile correctly when it
+ 'dependencies': [
+ '../content/content.gyp:content_common',
+ '../third_party/re2/re2.gyp:re2',
+ ],
+ 'include_dirs': [
+ '..',
+ '<(INTERMEDIATE_DIR)',
+ ],
+ 'sources': [
+ 'common/crx_file.cc',
+ 'common/crx_file.h',
+ 'common/draggable_region.cc',
+ 'common/draggable_region.h',
+ 'common/error_utils.cc',
+ 'common/error_utils.h',
+ 'common/event_filter.cc',
+ 'common/event_filter.h',
+ 'common/event_filtering_info.cc',
+ 'common/event_filtering_info.h',
+ 'common/event_matcher.cc',
+ 'common/event_matcher.h',
+ 'common/extension_paths.cc',
+ 'common/extension_paths.h',
+ 'common/extension_resource.cc',
+ 'common/extension_resource.h',
+ 'common/extension_urls.cc',
+ 'common/extension_urls.h',
+ 'common/extensions_client.cc',
+ 'common/extensions_client.h',
+ 'common/features/feature.cc',
+ 'common/features/feature.h',
+ 'common/features/feature_provider.cc',
+ 'common/features/feature_provider.h',
+ 'common/id_util.cc',
+ 'common/id_util.h',
+ 'common/install_warning.cc',
+ 'common/install_warning.h',
+ 'common/manifest.cc',
+ 'common/manifest.h',
+ 'common/manifest_constants.cc',
+ 'common/manifest_constants.h',
+ 'common/matcher/regex_set_matcher.cc',
+ 'common/matcher/regex_set_matcher.h',
+ 'common/matcher/string_pattern.cc',
+ 'common/matcher/string_pattern.h',
+ 'common/matcher/substring_set_matcher.cc',
+ 'common/matcher/substring_set_matcher.h',
+ 'common/matcher/url_matcher.cc',
+ 'common/matcher/url_matcher.h',
+ 'common/matcher/url_matcher_constants.cc',
+ 'common/matcher/url_matcher_constants.h',
+ 'common/matcher/url_matcher_factory.cc',
+ 'common/matcher/url_matcher_factory.h',
+ 'common/matcher/url_matcher_helpers.cc',
+ 'common/matcher/url_matcher_helpers.h',
+ 'common/one_shot_event.cc',
+ 'common/one_shot_event.h',
+ 'common/permissions/permissions_provider.h',
+ 'common/stack_frame.cc',
+ 'common/stack_frame.h',
+ 'common/switches.cc',
+ 'common/switches.h',
+ 'common/url_pattern.cc',
+ 'common/url_pattern.h',
+ 'common/url_pattern_set.cc',
+ 'common/url_pattern_set.h',
+ 'common/user_script.cc',
+ 'common/user_script.h',
+ 'common/view_type.cc',
+ 'common/view_type.h',
+ ],
+ # Disable c4267 warnings until we fix size_t to int truncations.
+ 'msvs_disabled_warnings': [ 4267, ],
+ },
+ {
+ 'target_name': 'extensions_browser',
+ 'type': 'static_library',
+ 'dependencies': [
+ 'extensions_common',
+ '../content/content.gyp:content_browser',
+ '../skia/skia.gyp:skia',
+ ],
+ 'include_dirs': [
+ '..',
+ '<(INTERMEDIATE_DIR)',
+ ],
+ 'sources': [
+ 'browser/extension_prefs_scope.h',
+ 'browser/extension_error.cc',
+ 'browser/extension_error.h',
+ 'browser/file_highlighter.cc',
+ 'browser/file_highlighter.h',
+ 'browser/file_reader.cc',
+ 'browser/file_reader.h',
+ 'browser/pref_names.cc',
+ 'browser/pref_names.h',
+ 'browser/view_type_utils.cc',
+ 'browser/view_type_utils.h',
+ ],
+ # Disable c4267 warnings until we fix size_t to int truncations.
+ 'msvs_disabled_warnings': [ 4267, ],
+ },
+ ]
+}
« no previous file with comments | « chrome/chrome_common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698