Chromium Code Reviews Chromium Code Reviews
Issue 23513035:
Create separate extensions_common and extensions_browser GYP targets. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 { | |
|
Nico
2013/10/23 18:26:59
This is missing chromium_source: 1. Adding this in
| |
| 6 'targets': [ | |
| 7 { | |
| 8 'target_name': 'extensions_common', | |
| 9 'type': 'static_library', | |
|
Nico
2013/10/23 18:26:59
Is this intentionally not a <(component)?
Yoyo Zhou
2013/10/24 01:23:43
I think something didn't compile correctly when it
| |
| 10 'dependencies': [ | |
| 11 '../content/content.gyp:content_common', | |
| 12 '../third_party/re2/re2.gyp:re2', | |
| 13 ], | |
| 14 'include_dirs': [ | |
| 15 '..', | |
| 16 '<(INTERMEDIATE_DIR)', | |
| 17 ], | |
| 18 'sources': [ | |
| 19 'common/crx_file.cc', | |
| 20 'common/crx_file.h', | |
| 21 'common/draggable_region.cc', | |
| 22 'common/draggable_region.h', | |
| 23 'common/error_utils.cc', | |
| 24 'common/error_utils.h', | |
| 25 'common/event_filter.cc', | |
| 26 'common/event_filter.h', | |
| 27 'common/event_filtering_info.cc', | |
| 28 'common/event_filtering_info.h', | |
| 29 'common/event_matcher.cc', | |
| 30 'common/event_matcher.h', | |
| 31 'common/extension_paths.cc', | |
| 32 'common/extension_paths.h', | |
| 33 'common/extension_resource.cc', | |
| 34 'common/extension_resource.h', | |
| 35 'common/extension_urls.cc', | |
| 36 'common/extension_urls.h', | |
| 37 'common/extensions_client.cc', | |
| 38 'common/extensions_client.h', | |
| 39 'common/features/feature.cc', | |
| 40 'common/features/feature.h', | |
| 41 'common/features/feature_provider.cc', | |
| 42 'common/features/feature_provider.h', | |
| 43 'common/id_util.cc', | |
| 44 'common/id_util.h', | |
| 45 'common/install_warning.cc', | |
| 46 'common/install_warning.h', | |
| 47 'common/manifest.cc', | |
| 48 'common/manifest.h', | |
| 49 'common/manifest_constants.cc', | |
| 50 'common/manifest_constants.h', | |
| 51 'common/matcher/regex_set_matcher.cc', | |
| 52 'common/matcher/regex_set_matcher.h', | |
| 53 'common/matcher/string_pattern.cc', | |
| 54 'common/matcher/string_pattern.h', | |
| 55 'common/matcher/substring_set_matcher.cc', | |
| 56 'common/matcher/substring_set_matcher.h', | |
| 57 'common/matcher/url_matcher.cc', | |
| 58 'common/matcher/url_matcher.h', | |
| 59 'common/matcher/url_matcher_constants.cc', | |
| 60 'common/matcher/url_matcher_constants.h', | |
| 61 'common/matcher/url_matcher_factory.cc', | |
| 62 'common/matcher/url_matcher_factory.h', | |
| 63 'common/matcher/url_matcher_helpers.cc', | |
| 64 'common/matcher/url_matcher_helpers.h', | |
| 65 'common/one_shot_event.cc', | |
| 66 'common/one_shot_event.h', | |
| 67 'common/permissions/permissions_provider.h', | |
| 68 'common/stack_frame.cc', | |
| 69 'common/stack_frame.h', | |
| 70 'common/switches.cc', | |
| 71 'common/switches.h', | |
| 72 'common/url_pattern.cc', | |
| 73 'common/url_pattern.h', | |
| 74 'common/url_pattern_set.cc', | |
| 75 'common/url_pattern_set.h', | |
| 76 'common/user_script.cc', | |
| 77 'common/user_script.h', | |
| 78 'common/view_type.cc', | |
| 79 'common/view_type.h', | |
| 80 ], | |
| 81 # Disable c4267 warnings until we fix size_t to int truncations. | |
| 82 'msvs_disabled_warnings': [ 4267, ], | |
| 83 }, | |
| 84 { | |
| 85 'target_name': 'extensions_browser', | |
| 86 'type': 'static_library', | |
| 87 'dependencies': [ | |
| 88 'extensions_common', | |
| 89 '../content/content.gyp:content_browser', | |
| 90 '../skia/skia.gyp:skia', | |
| 91 ], | |
| 92 'include_dirs': [ | |
| 93 '..', | |
| 94 '<(INTERMEDIATE_DIR)', | |
| 95 ], | |
| 96 'sources': [ | |
| 97 'browser/extension_prefs_scope.h', | |
| 98 'browser/extension_error.cc', | |
| 99 'browser/extension_error.h', | |
| 100 'browser/file_highlighter.cc', | |
| 101 'browser/file_highlighter.h', | |
| 102 'browser/file_reader.cc', | |
| 103 'browser/file_reader.h', | |
| 104 'browser/pref_names.cc', | |
| 105 'browser/pref_names.h', | |
| 106 'browser/view_type_utils.cc', | |
| 107 'browser/view_type_utils.h', | |
| 108 ], | |
| 109 # Disable c4267 warnings until we fix size_t to int truncations. | |
| 110 'msvs_disabled_warnings': [ 4267, ], | |
| 111 }, | |
| 112 ] | |
| 113 } | |
| OLD | NEW |
