Turn on warnings for the extensions target.

Turn on warnings for the extensions target.

Fix warnings that crept in since -Wall got dropped (in
https://codereview.chromium.org/23513035)

BUG=307668
R=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230500

[Nico, 2013-10-23 18:48:38]

First to lg wins!

[Yoyo Zhou, 2013-10-23 19:22:35]

LGTM
On Oct 23, 2013 11:48 AM, <thakis@chromium.org> wrote:

> Reviewers: Yoyo Zhou, benwells,
>
> Message:
> First to lg wins!
>
> Description:
> Turn on warnings for the extensions target.
>
> Fix warnings that crept in since -Wall got dropped (in
>
https://codereview.chromium.**org/23513035<https://codereview.chromium.org/23...
> )
>
> BUG=307668
>
> Please review this at
https://codereview.chromium.**org/37203005/<https://codereview.chromium.org/3...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files (+3, -1 lines):
>   extensions/common/manifest_**constants.cc
>   extensions/extensions.gyp
>
>
> Index: extensions/common/manifest_**constants.cc
> diff --git a/extensions/common/manifest_**constants.cc
> b/extensions/common/manifest_**constants.cc
> index b8d9ae254c82e960ced2f038f54f33**84244384d3..**
> 26df7ceabae7f3974b127364cbf53f**280683e1ee 100644
> --- a/extensions/common/manifest_**constants.cc
> +++ b/extensions/common/manifest_**constants.cc
> @@ -151,7 +151,6 @@ const char kUrlHandlers[] = "url_handlers";
>  const char kUrlHandlerTitle[] = "title";
>  const char kVersion[] = "version";
>  const char kWebAccessibleResources[] = "web_accessible_resources";
> -const char kWebRtc[] = "webrtc";
>  const char kWebURLs[] = "app.urls";
>  const char kWebview[] = "webview";
>  const char kWebviewAccessibleResources[] = "accessible_resources";
> Index: extensions/extensions.gyp
> diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
> index 0db3b4f45465f3c2e471a80948f531**ed82f92aee..**
> fe36c704064a6d38b46ae38fbc99e4**d0ec4bab0d 100644
> --- a/extensions/extensions.gyp
> +++ b/extensions/extensions.gyp
> @@ -3,6 +3,9 @@
>  # found in the LICENSE file.
>
>  {
> +  'variables': {
> +    'chromium_code': 1,
> +  },
>    'targets': [
>      {
>        'target_name': 'extensions_common',
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-23 19:33:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/37203005/1

[Nico, 2013-10-23 20:41:40]

Committed patchset #1 manually as r230500 (presubmit successful).